track signal usage for received messages #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agbpatro
force-pushed
the
track_signal_usage
branch
6 times, most recently
from
77ab764 to
ea7856a
Compare
agbpatro
commented
Jan 31, 2025
| @@ -27,7 +32,6 @@ func LoadApplicationConfiguration() (config *Config, logger *logrus.Logger, err | |||
|
|
|||
| config, err = loadApplicationConfig(configFilePath) | |||
| if err != nil { | |||
| logger.ErrorLog("read_application_configuration_error", err, nil) | |||
There was a problem hiding this comment.
we log this outside the method so don't need it here
agbpatro
force-pushed
the
track_signal_usage
branch
from
ea7856a to
22308b4
Compare
agbpatro
force-pushed
the
track_signal_usage
branch
from
22308b4 to
96fdad6
Compare
ThomasAlxDmy
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding metrics to track incoming signal usage
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: