Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update instructions to set fleet telemetry config #92

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

agbpatro
Copy link
Collaborator

@agbpatro agbpatro commented Jan 3, 2024

Description

Update documentation to share client config

Fixes # (issue)
#41

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

@patrickdemers6
Copy link
Collaborator

In fleet-api docs, the "Exhaustive list of <field_to_stream> is present here." links to a specific commit. Should be updated to reference main.

It would also be great to include how to unenroll a vehicle before the exp.

@agbpatro
Copy link
Collaborator Author

agbpatro commented Jan 3, 2024

In fleet-api docs, the "Exhaustive list of <field_to_stream> is present here." links to a specific commit. Should be updated to reference main.

It would also be great to include how to unenroll a vehicle before the exp.

will update documentation.
we will be adding unenrolling support soon.

@agbpatro agbpatro merged commit c6d7edf into main Jan 3, 2024
3 checks passed
@agbpatro agbpatro deleted the update_client_config branch January 3, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants