Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger dispatcher logs payloads in json string #97

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

agbpatro
Copy link
Collaborator

Description

In #95, logger started printed records as protobuf bytes which is not that useful. This PR ensures that always json payload is logged, regardless of value of transmit_decoded_records

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

@agbpatro agbpatro force-pushed the fix_logger_dispatcher branch from 99ae134 to 31a34db Compare January 11, 2024 06:25
@agbpatro agbpatro merged commit 9f8ce80 into main Jan 11, 2024
3 checks passed
@agbpatro agbpatro deleted the fix_logger_dispatcher branch January 11, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants