Update to Java version 17 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohagarwal
force-pushed
the
feature/update-3rdparty-deps
branch
from
a73a272 to
da8134f
Compare
shrijeet-tesla
approved these changes
Mar 29, 2024
Update the following dependencies to newer versions so they work with Java 17: * mockito * apache commons-lang3 * zookeeper * jackson Some tests were updated to work with newer version of mockito. Update Bazel to version 6.5.0 and pull in new version of rules_java to use the latest JDK for compilation. Build source code targeting Java 17 bytecode, and run tests with Java 17 as well.
rohagarwal
force-pushed
the
feature/update-3rdparty-deps
branch
from
da8134f to
5c3a1d6
Compare
rohagarwal
changed the title
|
Updated this PR to use Java 17 for building and testing, since some of the updated dependencies do not work with Java 8 any more 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the following dependencies to newer versions so they work with Java 17:
Some tests were updated to work with newer version of mockito.
Update Bazel to version 6.5.0 and pull in new version of rules_java to
use the latest JDK for compilation. Build source code targeting Java 17
bytecode, and run tests with Java 17 as well.