Skip to content

Strings now exposed externally as array of UCS-2 codepoints #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tm-rampart merged 82 commits into from
Oct 11, 2014
Merged

Strings now exposed externally as array of UCS-2 codepoints #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
f9c1480
No more utf8proc
natevw Oct 10, 2014
2223064
Adds UCS2 length test
tcr Mar 24, 2014
1254468
Adds UTF8 upper/lower functions and tests.
tcr Mar 24, 2014
062c1e2
Adds UTF-8 char methods (toupper, tolower, encode).
tcr Mar 24, 2014
3ef553e
Renames UCS2 functions to reflect operation on strs.
tcr Mar 24, 2014
9a8ae2b
Implements fromCharCode in terms of UTF-8.
tcr Mar 24, 2014
9031cfe
Updates encoding test to work with npm test
tcr Mar 24, 2014
23670b6
Adds string indexing support for ucs2 characters.
tcr Mar 24, 2014
96465b6
fromCharCode should truncate UTF-16 values
tcr Mar 24, 2014
497a367
Length is properly reported as UCS-2
tcr Mar 24, 2014
69b27ce
Implements toUpperCase and toLowerCase
tcr Mar 24, 2014
d9a1b14
fix building utf8 branch
natevw Sep 15, 2014
3f1b410
a couple important (failing!) string tests
natevw Sep 17, 2014
77a40f6
move str charAt code to __index so they both work [approximately] rig…
natevw Sep 17, 2014
d38be4a
[confused/broken] first pass at lookup, wrong output and such will ne…
natevw Sep 19, 2014
f81dc9b
get string length working, yay!
natevw Sep 19, 2014
22e7c77
refactor 16to8 so as to make __index work now too :-)
natevw Sep 19, 2014
306be1c
fix replacement vs. noncharacter, add note about overall futility of …
natevw Sep 19, 2014
681e09f
add note re. fun
natevw Sep 19, 2014
ea032a6
make str_lookup consistent so that 8=Lua, 16=Sanity
natevw Sep 22, 2014
f04b96c
implement indexOf using ucs2_str_lookup
natevw Sep 22, 2014
4c3aff9
fix global leak in str_proto.indexOf
natevw Sep 22, 2014
d496359
remove apparent debug log
natevw Sep 22, 2014
76d10f7
implement lastIndexOf using ucs2_str_lookup methods
natevw Sep 22, 2014
ec94195
add one more lastIndexOf test
natevw Sep 22, 2014
36c6adc
use actually multibyte emoji as originally intended
natevw Sep 23, 2014
6eb8a63
implement str_proto.slice using ucs2_str_lookup
natevw Sep 23, 2014
2d7817a
implement proper str_proto.substring
natevw Sep 23, 2014
cecda50
coupla notes/cleanup
natevw Sep 23, 2014
16fe7c9
handle string offset overflow by truncation (this seems correct since…
natevw Sep 23, 2014
9d2b114
implement str_proto.substr
natevw Sep 23, 2014
ebbde3f
"fix" Buffer to stay in raw string land for now
natevw Sep 24, 2014
c366aa8
fix l_tm_utf8_char_encode
natevw Sep 24, 2014
46228a7
fix encoding test count
natevw Sep 24, 2014
a177831
fix str_proto.lastIndexOf regression in issue-runtime-185
natevw Sep 24, 2014
3c9e908
re-enable tests for THE NEXT FRONTIER
natevw Sep 24, 2014
3e9d435
fix encoding tests to compare properly
natevw Sep 24, 2014
cfd3e33
start on potential colony_tolstring implementation
natevw Sep 26, 2014
31728b0
fix memory leak in utf8 upper/lower usage, factor out (but do not yet…
natevw Sep 29, 2014
3ab3425
first pass at actual internal->utf8 conversion (bugs)
natevw Oct 1, 2014
352a823
fix some edge cases in utf8 output logic
natevw Oct 1, 2014
94c0e27
simplify end-of-string handling by iterating through NUL-terminator (…
natevw Oct 1, 2014
81c2459
"fix" up ut8_len for NUL terminator count
natevw Oct 2, 2014
29a9cd9
less sketchy handling of NUL byte, now the only caveat is mismatched …
natevw Oct 2, 2014
c9da144
this by no means fully fixes String object, but at least fixes loop a…
natevw Oct 2, 2014
72f4b8d
review String.fromCharCode and add test
natevw Oct 2, 2014
331e042
get uri encode/decode functions mostly working (should be good once t…
natevw Oct 3, 2014
5f608f2
add note about escape function
natevw Oct 3, 2014
d707696
implement Unicode-capable escape
natevw Oct 3, 2014
a93ce77
implement unescape for good measure
natevw Oct 3, 2014
6a1db03
clean up tests a bit (comments -> actual tests)
natevw Oct 3, 2014
6179a03
give colony string stack helpers much clearer names
natevw Oct 3, 2014
ea8a975
implement tm_str_from_utf8 (albeit with some fudging) — all encoding/…
natevw Oct 3, 2014
5a23af2
fix bogus memory management — we cannot return memory we probably jus…
natevw Oct 3, 2014
f296ec7
back away from regression in test/issues/issue-runtime-289.js caused …
natevw Oct 3, 2014
803eb2b
increase odds of successful conversion of line noise to CESU-8. this …
natevw Oct 3, 2014
1031175
fix that mismerged itoa thing that has been plaguing this branch…
natevw Oct 3, 2014
1fed20c
clarify buffer->string conversion, needed now that Buffer has gotten …
natevw Oct 3, 2014
e13a358
fix generating string from utf8 buffer, start clarifying other conver…
natevw Oct 4, 2014
820baa6
fix up base64 variable names to reveal its correctness
natevw Oct 4, 2014
6db1a36
add poison pill and rough start on antidote
natevw Oct 4, 2014
37b97a5
finish implementing correct Buffer to ascii/binary strings, improving…
natevw Oct 6, 2014
5b160be
remove unused tm_ucs2_str_length
natevw Oct 6, 2014
c8e6120
clean up ucs2_str_codeat (née charat)
natevw Oct 6, 2014
a9032b9
move char_encode to ucs2 suite (inverse of str_codeat)
natevw Oct 6, 2014
4fbcf4e
reorganize "final" string handling functions to better clarify that s…
natevw Oct 6, 2014
439cdb3
"optimize" UTF-8 to/from conversions
natevw Oct 6, 2014
b95a138
Revert ""optimize" UTF-8 to/from conversions"
natevw Oct 6, 2014
165ed9c
get rid of now-pointless comment
natevw Oct 6, 2014
ecdfbce
avoid accidental globals caught by @tcr in review
natevw Oct 7, 2014
5703ae0
add a few more string indexing test cases to lock in some (correct) b…
natevw Oct 7, 2014
30e0cf4
properly, out-of-range string indexing returns `undefined` rather tha…
natevw Oct 7, 2014
b954866
probably makes sense to explicitly test corrct string length at some …
natevw Oct 7, 2014
4ff8963
we can use math.huge here now, so avoid extra str.length calls
natevw Oct 7, 2014
5901a31
back to ASCII-only casemappings for now, see https://github.com/tesse…
natevw Oct 9, 2014
9bafcb3
drop stale comment
natevw Oct 10, 2014
7484f14
no more utf8proc uses
natevw Oct 10, 2014
1ca3a74
fix regression in proper handling of bad UTF-8 lead sequence byte
natevw Oct 10, 2014
72f41fd
Fixes misplaced .length for .n.
tcr Oct 10, 2014
8f26859
Fixes signedness issues.
tcr Oct 10, 2014
1926149
Updates Travis to use "make test" instead of "npm test".
tcr Oct 10, 2014
dc1d438
Fixes running bytecode through require()
tcr Oct 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ install:
- sudo apt-get -y install gyp
script:
- make colony
- npm test
- make test

git:
submodules: false
2 changes: 1 addition & 1 deletion .travis.osx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ install:
- make update
script:
- make colony
- npm test
- make test

git:
submodules: false
131 changes: 0 additions & 131 deletions deps/utf8proc/Changelog
View file
Open in desktop

This file was deleted.

64 changes: 0 additions & 64 deletions deps/utf8proc/LICENSE
View file
Open in desktop

This file was deleted.

68 changes: 0 additions & 68 deletions deps/utf8proc/Makefile
View file
Open in desktop

This file was deleted.

Loading