Added argument.callee and simple test #597
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Does this implementation leave room for the necessary strict mode poison pill? #573 (comment) |
Contributor
Author
|
It does now! kinda. If strict mode is enabled (and once we've implemented it) we'll throw the exact error Node does here: Note you can manually set strict mode for arguments here: Ken by the way; nice to electronically meet you, and good call on looking out for future problems! |
Contributor
|
Nice! Ken? |
Member
|
Requires: tessel/colony-compiler#36 |
…ings Mild overhaul to finish up Buffer encoding work which was started in the ["Strings" pull request](#542) but wasn't really fully implemented or thoroughly checked over. Highlights: - adds utf16le encoding/decoding (which had been completely absent) - improves ascii/binary/hex/base64 logic too - generally cleaner in/out logic
…r writes Fixes #319 for "PC" use cases. Depends on tessel/t1-cli#166 — otherwise as it sits now, the CLI will silently drop the new "raw" messages by default.
tm-rampart
added a commit
that referenced
this pull request
Jan 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does it need more comprehensive testing?
Review. Land. Love.