Buffer::fill with strings #666
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The build fails because node v0.10 dosen't support filling with a longer string than one character (see #659). How do you guys want to handle this? I think that using the whole string is just an extra feature and won't break any code already in place. This will also be the stable behaviour as soon as 0.12 is out the door so I think that we should implement it right away.... |
Contributor
|
@LinusU, I'd prefer if we could try to stick as closely to the released Node version as possible. Could you break this up into two PRs: one with fill for a single character and the other for an entire string? We'll merge the compatible one immediately and rebase/merge the latter when 0.12 is released. |
This was referenced Dec 1, 2014
Contributor
Author
tm-rampart
added a commit
that referenced
this pull request
Dec 2, 2014
Related to #666 This is the Node.js version `0.10.x` implementation of `Buffer.fill`. @johnnyman727 we can merge this for now and then when Node.js `0.12.x` is released we'll merge the next one that I'll submit in 5 minutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #659.
All the current tests still passes and I've added some new ones as well.