Supports loading process.env when in Colony CLI mode. #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Doesn't leave a file in /tmp
* Avoids a symlink race vulnerability
* May not break on Windows
* Checks that the colony-compiler path is nonempty, because
os.exit didn't return the passed error code before (#663)
Contributor
There was a problem hiding this comment.
This will break in the case of export THING="line1"$'\n'"line2" (which might be what we need for TM_PROXY_CERT)
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
it gets worse:
export THING1=a$'\n'THING2=c
echo "$THING1"
env
Contributor
|
@tcr what needs to happen to get this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.