You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
I now replaced release 5.3.5-rc1 by 5.4.0-rc1. More pull requests can be added in -rc2 or a final 5.4.0, but the two suggested ones also have API changes and I am still unsure whether they should be merged in their current form.
cab5658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4070 (Allow for text angle/gradient to be retrieved) extends API, so the next tesseract version should 5.4.0 or skipped in the V5.3.5...
cab5658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, I should have made a 5.4.0-rc1. I'll do that now and delete the wrong release.
cab5658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this #4171? It was also suggested for 5.4.0...
cab5658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this #4074
cab5658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now replaced release 5.3.5-rc1 by 5.4.0-rc1. More pull requests can be added in -rc2 or a final 5.4.0, but the two suggested ones also have API changes and I am still unsure whether they should be merged in their current form.
cab5658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are open for a while without any major objections.
As we are already modifying API I would suggest including them for rc2.