Skip to content

Commit

Permalink
Update PulsarContainer script and defaults for compatibility
Browse files Browse the repository at this point in the history
Replaced deprecated script arguments with updated ones to ensure proper configuration handling. Updated Pulsar image to version 3.0.8 and modified default file paths for better alignment with expected conventions.
  • Loading branch information
David Erik Jensen committed Jan 29, 2025
1 parent 888da44 commit dc46d76
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/Testcontainers.Pulsar/PulsarBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ namespace Testcontainers.Pulsar;
[PublicAPI]
public sealed class PulsarBuilder : ContainerBuilder<PulsarBuilder, PulsarContainer, PulsarConfiguration>
{
public const string PulsarImage = "apachepulsar/pulsar:3.0.6";
public const string PulsarImage = "apachepulsar/pulsar:3.0.8";

public const ushort PulsarBrokerDataPort = 6650;

public const ushort PulsarWebServicePort = 8080;

public const string StartupScriptFilePath = "/testcontainers.sh";

public const string SecretKeyFilePath = "/pulsar/secret.key";
public const string SecretKeyFilePath = "/tmp/secret.key";

public const string Username = "test-user";

Expand Down
2 changes: 1 addition & 1 deletion src/Testcontainers.Pulsar/PulsarContainer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ internal Task CopyStartupScriptAsync(CancellationToken ct = default)
startupScript.WriteLine("export brokerClientAuthenticationParameters=token:$(bin/pulsar tokens create --secret-key $PULSAR_PREFIX_tokenSecretKey --subject $superUserRoles)");
startupScript.WriteLine("export CLIENT_PREFIX_authParams=$brokerClientAuthenticationParameters");
startupScript.WriteLine("bin/apply-config-from-env.py conf/standalone.conf");
startupScript.WriteLine("bin/apply-config-from-env-with-prefix.py CLIENT_PREFIX_ conf/client.conf");
startupScript.WriteLine("bin/apply-config-from-env.py --prefix CLIENT_PREFIX_ conf/client.conf");
}

startupScript.Write("bin/pulsar standalone");
Expand Down

0 comments on commit dc46d76

Please sign in to comment.