chore: Remove Sonar findings; update PR template (#1069)

testcontainers · Dec 8, 2023 · e3be24f · e3be24f
1 parent 8dfc951
commit e3be24f
Show file tree

Hide file tree

Showing 9 changed files with 3 additions and 13 deletions.
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -1,7 +1,3 @@
-<!-- Type of change
-Please label this PR with one of the existing labels, depending on the scope of your change.
--->
-
 ## What does this PR do?
 
 <!-- Mandatory

diff --git a/Packages.props b/Packages.props
@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project>
   <ItemGroup>
-    <GlobalPackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="6.0.0" />
     <PackageReference Update="Docker.DotNet" Version="3.125.15" />
     <PackageReference Update="Docker.DotNet.X509" Version="3.125.15" />
     <PackageReference Update="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" />

diff --git a/build.cake b/build.cake
@@ -1,4 +1,4 @@
-#tool nuget:?package=dotnet-sonarscanner&version=5.14.0
+#tool nuget:?package=dotnet-sonarscanner&version=5.15.0
 
 #addin nuget:?package=Cake.Sonar&version=1.1.32
 

diff --git a/src/Testcontainers.ActiveMq/Usings.cs b/src/Testcontainers.ActiveMq/Usings.cs
@@ -1,5 +1,4 @@
 global using System;
-global using System.Threading.Tasks;
 global using Docker.DotNet.Models;
 global using DotNet.Testcontainers;
 global using DotNet.Testcontainers.Builders;

diff --git a/src/Testcontainers.Couchbase/CouchbaseBuilder.cs b/src/Testcontainers.Couchbase/CouchbaseBuilder.cs
@@ -580,7 +580,7 @@ await Task.Delay(TimeSpan.FromSeconds(1), cancellationToken)
                 }
             }
 
-            throw new Exception($"Unable to configure Couchbase. The HTTP request '{request.RequestUri}' did not complete successfully.");
+            throw new HttpRequestException($"Unable to configure Couchbase. The HTTP request '{request.RequestUri}' did not complete successfully.");
         }
     }
 }
diff --git a/src/Testcontainers.RabbitMq/Usings.cs b/src/Testcontainers.RabbitMq/Usings.cs
@@ -1,5 +1,4 @@
 global using System;
-global using System.Threading.Tasks;
 global using Docker.DotNet.Models;
 global using DotNet.Testcontainers;
 global using DotNet.Testcontainers.Builders;

diff --git a/src/Testcontainers.RavenDb/Usings.cs b/src/Testcontainers.RavenDb/Usings.cs
@@ -1,5 +1,4 @@
 global using System;
-global using System.Threading.Tasks;
 global using Docker.DotNet.Models;
 global using DotNet.Testcontainers.Builders;
 global using DotNet.Testcontainers.Configurations;

diff --git a/src/Testcontainers.SqlEdge/Usings.cs b/src/Testcontainers.SqlEdge/Usings.cs
@@ -1,6 +1,5 @@
 global using System.Collections.Generic;
 global using System.Linq;
-global using System.Threading.Tasks;
 global using Docker.DotNet.Models;
 global using DotNet.Testcontainers;
 global using DotNet.Testcontainers.Builders;

diff --git a/src/Testcontainers/Images/DockerImage.cs b/src/Testcontainers/Images/DockerImage.cs
@@ -84,8 +84,7 @@ public DockerImage(
           .Where(imageComponent => !string.IsNullOrEmpty(imageComponent))
           .DefaultIfEmpty(string.Empty)
           .First()
-          .Split('/')
-          .First();
+          .Split('/')[0];
 
         if (firstSegmentOfRepository.IndexOfAny(new[] { '.', ':' }) >= 0)
         {
-Original file line number
+Diff line change
@@ Expand Up @@
                     }
                 }
-                throw new Exception($"Unable to configure Couchbase. The HTTP request '{request.RequestUri}' did not complete successfully.");
+                throw new HttpRequestException($"Unable to configure Couchbase. The HTTP request '{request.RequestUri}' did not complete successfully.");
             }
         }
     }