Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Always run the Upload Test And Coverage Results step #1113

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Feb 11, 2024

Use if: always() instead of if: true in order to always run a step even if the previous one fails. This is surprising but that's how GitHub actions work, see https://stackoverflow.com/questions/58858429/how-to-run-a-github-actions-step-even-if-the-previous-step-fails-while-still-f#comment112735158_58859404

Proof that if: true does not work.

Screenshot 2024-02-11 at 13 24 19

Use `if: always() `instead of `if: true` in order to always run a step even if the previous one fails. This is surprising but that's how GitHub actions work, see https://stackoverflow.com/questions/58858429/how-to-run-a-github-actions-step-even-if-the-previous-step-fails-while-still-f#comment112735158_58859404
Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 862500b
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/65c8bccbedb07a0007cc1aa6
😎 Deploy Preview https://deploy-preview-1113--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn merged commit 5600106 into testcontainers:develop Feb 12, 2024
11 checks passed
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@0xced 0xced deleted the feature/if-always branch February 12, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants