Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kafka add kraft support #1353

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

SukharevAndrey
Copy link

@SukharevAndrey SukharevAndrey commented Jan 27, 2025

What does this PR do?

Adds support for KRaft mode using Confluent images. Add support for and official Apache Kafka images (apache/kafka and apache/kafka-native).

Why is it important?

Current implementation does not allow the end user to use images other than confluent one. It also does not support KRaft mode, but it is supported in Go, Java and Python implementations.

The goal was to enable missing functionality.

Related issues

The difference between implementations:

  1. Supports for KRaft in Confluent image too
  2. Throws an error if KRaft is not supported in provided image
  3. Does not require another class to use. All happens in the same class without breaking backward compatibility.
  4. Makes the project nullable.
  5. Tests different setups.

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit aca308c
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/6797c279a1a96e0008ba4bfd
😎 Deploy Preview https://deploy-preview-1353--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add Apache Kafka Test Container to Kafka module
1 participant