-
-
Notifications
You must be signed in to change notification settings - Fork 320
chore: Replace Cake .NET Tool with Cake Frosting #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. There are a two issues:
- When the build project is added to the solution, the build fails on Windows. It looks like it's trying to build the project again, which causes the failure (removed it from the solution file for now):
error MSB3027: Could not copy "C:\Sources\dotnet\testcontainers-dotnet\build\obj\Debug\net9.0\apphost.exe" to "bin\Debug\net9.0\Testcontainers.Build.exe". Exceeded retry count of 10. Failed. The file is locked by: "Testcontainers.Build (24504)" error MSB3021: Unable to copy file "C:\Sources\dotnet\testcontainers-dotnet\build\obj\Debug\net9.0\apphost. exe" to "bin\Debug\net9.0\Testcontainers.Build.exe". The process cannot access the file 'C:\Sources\dotnet\testcontainers-dotnet\build\bin\Debug\net9.0\Testcontainers.Build.exe' because it is being used by another process.
- Also, if you check the build pipeline, it's not running the Windows tests (Windows-hosted runner).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I updated the GitHub step to use bash
and install the SonarScanner again.
What does this PR do?
This pull request migrates from Cake .NET Tool to Cake Frosting.
Why is it important?
From the Cake Runners documentation:
Since the Cake project was already using multiple files, converting it to Cake Frosting makes sense.
I remember debugging a Cake script some years ago and the experience was not really pleasant. Debugging and refactoring becomes really smooth with full IDE support.
Also, as suggested by the maintainer of the Cake Git add-in, using Cake.Frosting.Git instead of Cake.Git solves the issue of LibGit2Sharp failing on Apple Silicon! 🥳 (That was the original motivation behind this pull request.)
Related issues
/cc @digital88
How to test this PR
The Continuous Integration & Delivery workflow has been updated to use Cake Frosting instead of the Cake .NET Tool (i.e. running
./build.sh
instead ofdotnet cake
) so testing will be done automatically by GitHub actions.