Skip to content

RyukResourceReaper log initial expected errors at debug #10802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RyukResourceReaper log initial expected errors at debug #10802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions core/src/main/java/org/testcontainers/utility/RyukResourceReaper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.testcontainers.utility;

import com.github.dockerjava.api.command.CreateContainerCmd;
import java.util.concurrent.atomic.AtomicReference;
import lombok.SneakyThrows;
import lombok.extern.slf4j.Slf4j;
import org.rnorth.ducttape.ratelimits.RateLimiter;
Expand Down Expand Up @@ -78,6 +79,7 @@ private synchronized void maybeStart() {
ryukContainer.start();

CountDownLatch ryukScheduledLatch = new CountDownLatch(1);
AtomicReference<IOException> lastConnectException = new AtomicReference<>();

String host = ryukContainer.getHost();
Integer ryukPort = ryukContainer.getFirstMappedPort();
Expand Down Expand Up @@ -117,7 +119,12 @@ private synchronized void maybeStart() {
}
}
} catch (IOException e) {
log.warn("Can not connect to Ryuk at {}:{}", host, ryukPort, e);
if (ryukScheduledLatch.getCount() != 0) {
log.debug(CANNOT_CONNECT, host, ryukPort, e);
lastConnectException.set(e);
} else {
log.warn(CANNOT_CONNECT, host, ryukPort, e);
}
}
});
}
Expand All @@ -129,7 +136,10 @@ private synchronized void maybeStart() {
// We need to wait before we can start any containers to make sure that we delete them
if (!ryukScheduledLatch.await(TestcontainersConfiguration.getInstance().getRyukTimeout(), TimeUnit.SECONDS)) {
log.error("Timed out waiting for Ryuk container to start. Ryuk's logs:\n{}", ryukContainer.getLogs());
throw new IllegalStateException(String.format("Could not connect to Ryuk at %s:%s", host, ryukPort));
throw new IllegalStateException(String.format("Could not connect to Ryuk at %s:%s", host, ryukPort),
lastConnectException.get());
}
}

private static final String CANNOT_CONNECT = "Cannot connect to Ryuk at {}:{}";
}