Don't run Rails 7.2 on Ruby 3.0

testdouble · Sep 21, 2024 · 3b9bfca · 3b9bfca
1 parent 4e596e8
commit 3b9bfca
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -9,6 +9,11 @@ jobs:
     strategy:
       matrix:
         ruby-version: ['3.0', '3.3']
+        gemfile: ['Gemfile', 'Gemfile.rails71']
+        exclude:
+          # Rails 7.2 requires Ruby 3.1+
+          - ruby-version: '3.0'
+            gemfile: 'Gemfile'
 
     steps:
       - uses: actions/checkout@v4
@@ -18,4 +23,4 @@ jobs:
           bundler-cache: true
 
       - name: Run tests
-        run: ./script/test
+        run: ./script/test ${{matrix.gemfile}}
diff --git a/script/test b/script/test
@@ -13,7 +13,7 @@ cd ..
 
 echo "---> Running tests"
 bundle exec rake
-./script/test_example_app
+./script/test_example_app $@
 
 bundle exec rake test
 

diff --git a/script/test_example_app b/script/test_example_app
@@ -2,6 +2,8 @@
 
 set -e
 
+gemfile="${1-Gemfile}"
+
 run_example_tests() {
   bundle
   yarn install
@@ -21,8 +23,6 @@ run_example_tests() {
 
 cd example
 
-echo "---> Running example tests with default Gemfile"
-run_example_tests
+echo "---> Running example tests with ${gemfile}"
+BUNDLE_GEMFILE=$gemfile run_example_tests
 
-echo "---> Running example tests with Gemfile.rails71"
-BUNDLE_GEMFILE=Gemfile.rails71 run_example_tests