-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on pbr #95
Remove dependency on pbr #95
Conversation
... and instead use setuptools via pyproject.toml. pbr does not seem to be well mainained any more, and using pyproject.toml is the modern approach to packaging in Python.
@jelmer I had a look at how hatchling is used in testtools, and there were a couple of things I am not familiar with, e.g. setuptools_scm, so for now I just migrated to setuptools via pyproject.toml analogous how it is done as in subunit. I hope that is ok. |
Thanks for the review! |
@jelmer I do not have merge permissions on this repo. Would you please merge the PR and create a new release? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I meant hatchling, not setuptools_scm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
I'm confused here - pbr is still maintained. No objection to migrating, but the premise does seem inaccurate. |
@rbtcollins Please see #94 (comment) - there is no support for Python 3.12 even that this version was released 1.5 years ago. And I never claimed pbr is unmaintained, it is just not maintained well. |
fixtures/_version.py
Outdated
@@ -0,0 +1,16 @@ | |||
# file generated by setuptools_scm | |||
# don't change, don't track in version control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says to not track it, but it's checked in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, removed it.
Thanks for merging, @jelmer. Would you be able to cut a new release? |
I've done you one better and sent you an invite on pypi |
... and instead use setuptools via pyproject.toml.
pbr does not seem to be well mainained any more, and using pyproject.toml is the modern approach to packaging in Python.
fixes #94
This change is