Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on pbr #95

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

jugmac00
Copy link
Contributor

@jugmac00 jugmac00 commented Feb 6, 2025

... and instead use setuptools via pyproject.toml.

pbr does not seem to be well mainained any more, and using pyproject.toml is the modern approach to packaging in Python.

fixes #94


This change is Reviewable

... and instead use setuptools via pyproject.toml.

pbr does not seem to be well mainained any more, and using
pyproject.toml is the modern approach to packaging in Python.
@jugmac00
Copy link
Contributor Author

jugmac00 commented Feb 6, 2025

@jelmer I had a look at how hatchling is used in testtools, and there were a couple of things I am not familiar with, e.g. setuptools_scm, so for now I just migrated to setuptools via pyproject.toml analogous how it is done as in subunit. I hope that is ok.

@jugmac00
Copy link
Contributor Author

jugmac00 commented Feb 6, 2025

Thanks for the review!

@jugmac00
Copy link
Contributor Author

jugmac00 commented Feb 6, 2025

@jelmer I do not have merge permissions on this repo. Would you please merge the PR and create a new release? Thank you!

Copy link

@bigjools bigjools left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant hatchling, not setuptools_scm!

Copy link
Member

@jelmer jelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@jugmac00
Copy link
Contributor Author

jugmac00 commented Feb 10, 2025

Thanks for the review. I applied the changes as requested. Please double check the version import, as that one is not entirely clear to me. I will squash the commits after a successful review.
@jelmer / @bigjools

@jugmac00 jugmac00 requested review from bigjools and jelmer February 10, 2025 09:50
@rbtcollins
Copy link
Member

I'm confused here - pbr is still maintained. No objection to migrating, but the premise does seem inaccurate.

@jugmac00
Copy link
Contributor Author

@rbtcollins Please see #94 (comment) - there is no support for Python 3.12 even that this version was released 1.5 years ago.

And I never claimed pbr is unmaintained, it is just not maintained well.

@@ -0,0 +1,16 @@
# file generated by setuptools_scm
# don't change, don't track in version control
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says to not track it, but it's checked in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removed it.

@jugmac00 jugmac00 requested a review from jelmer February 10, 2025 11:34
@jelmer jelmer enabled auto-merge February 10, 2025 11:37
@jelmer jelmer dismissed bigjools’s stale review February 10, 2025 15:15

addressed by jugmac00

@jelmer jelmer merged commit c25ca17 into testing-cabal:master Feb 10, 2025
10 checks passed
@jugmac00 jugmac00 deleted the remove-dependency-on-pbr branch February 10, 2025 16:20
@jugmac00
Copy link
Contributor Author

Thanks for merging, @jelmer. Would you be able to cut a new release?

@jelmer
Copy link
Member

jelmer commented Feb 10, 2025

Thanks for merging, @jelmer. Would you be able to cut a new release?

I've done you one better and sent you an invite on pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on pbr
4 participants