Daisy chain tests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds daisy chain tests for op-geth, backed by the production Goerli nodes to provide the actual L2Geth execution.
…0/daisy-chain-tests
pcw109550
force-pushed
the
pcw109550/daisy-chain-tests
branch
3 times, most recently
from
b7eece2
to
41ac577
Compare
pcw109550
force-pushed
the
pcw109550/daisy-chain-tests
branch
from
41ac577
to
84374fc
Compare
ImTei
approved these changes
Jul 13, 2023
|
CI passing with op-erigon version https://github.com/testinprod-io/op-erigon/releases/tag/v2.43.0-0.1.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors and fixes ethereum-optimism#79.
Overview
Adds tests for the daisy chain.
The test compares two RPC responses:
New test suite:
simulators/optimism/daisy-chain.Tests for RPC methods that involve execution on l2geth:
debug_traceBlockByNumberdebug_traceBlockByHashdebug_traceTransactiondebug_traceCalleth_calleth_estimateGasIssues
debug_traceBlockByNumber,debug_traceBlockByHash,debug_traceTransaction's responses were incorrectly compared because those responses where stored at invalid structtxTraceResult. This struct removes necessary fields which must be compared for sanity check. Fixed by using type asinterface{}.While implementing, noticed op-erigon bugs. Fixed at testinprod-io/op-erigon#79, testinprod-io/op-erigon#80, testinprod-io/op-erigon#81.
After these op-erigon fixes are merged(and released), hive ci will pass. Locally tested.