Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors and fixes ethereum-optimism#79.
Overview
Adds tests for the daisy chain.
The test compares two RPC responses:
New test suite:
simulators/optimism/daisy-chain
.Tests for RPC methods that involve execution on l2geth:
debug_traceBlockByNumber
debug_traceBlockByHash
debug_traceTransaction
debug_traceCall
eth_call
eth_estimateGas
Issues
debug_traceBlockByNumber
,debug_traceBlockByHash
,debug_traceTransaction
's responses were incorrectly compared because those responses where stored at invalid structtxTraceResult
. This struct removes necessary fields which must be compared for sanity check. Fixed by using type asinterface{}
.While implementing, noticed op-erigon bugs. Fixed at testinprod-io/op-erigon#79, testinprod-io/op-erigon#80, testinprod-io/op-erigon#81.
After these op-erigon fixes are merged(and released), hive ci will pass. Locally tested.