Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert teufel namespace #2

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Convert teufel namespace #2

merged 5 commits into from
Jan 10, 2025

Conversation

rocketage
Copy link
Collaborator

Goals

The main objective of this PR is to make this fork public, so Spryker projects using PHP8.x and later versions of Spryker can work with the module.

We will need to push it to packagist, so we need to update the vendor name and in turn the PHP namespace.

I also made some further changes to fit with the latest changes from Symfony and Spryker.

Changes

  • Change vendor name and namespace
  • Remove support for PHP7.4 and PHP8.0, in line with latest Spryker requirements
  • Pin psr/log package to prevent conflicts with Symfony debug
  • Prevent CacheContext from deleting the database config (no idea how this worked previously...)

@skrollme
Copy link

skrollme commented Jan 6, 2025

Looks like docker-compose is missing in the stock ubuntu-image during CI. You can install it e.g. via an extra step after "Checkout code" in .github/workflows/ci.yml:

-   name: "Install docker-compose"
    run: |
        sudo curl -L "https://github.com/docker/compose/releases/download/2.12.0/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
        sudo chmod +x /usr/local/bin/docker-compose

@rocketage
Copy link
Collaborator Author

Looks like docker-compose is missing in the stock ubuntu-image during CI. You can install it e.g. via an extra step after "Checkout code" in .github/workflows/ci.yml:

-   name: "Install docker-compose"
    run: |
        sudo curl -L "https://github.com/docker/compose/releases/download/2.12.0/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose
        sudo chmod +x /usr/local/bin/docker-compose

Thanks for the tip. I created this PR and immediately went into holiday mode, so didn't see this until today. The github action ubuntu did not like the v2 version of docker compose, so I had to switch to v1 which seems to work. Although its deprecated I think it's ok for this current PR, we can refactor the CI in a future PR.

@hgajjar hgajjar merged commit 9dc339a into main Jan 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants