Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix bug in guide_circles() with multiple layers #59

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

teunbrand
Copy link
Owner

This PR aims to fix #58.

The issue was that the layer-rejection mechanism of GuideLegend wasn't used properly.

devtools::load_all("~/packages/legendry/")
#> ℹ Loading legendry
#> Loading required package: ggplot2

ggplot(mtcars) +
  aes(x = mpg, y = hp, color = cyl) +
  geom_point(aes(x = mpg, y = hp, fill = cyl, size=hp), shape=21) +
  geom_smooth(aes(x = mpg, y = hp), inherit.aes = FALSE) +
  scale_size(breaks = c(100, 250), guide = "circles")
#> `geom_smooth()` using method = 'loess' and formula = 'y ~ x'

Created on 2025-02-17 with reprex v2.1.1

@teunbrand teunbrand changed the title Fix bug in guide_circles() with multiple layers 🐛 Fix bug in guide_circles() with multiple layers Feb 17, 2025
@teunbrand teunbrand merged commit 2286d44 into main Feb 17, 2025
7 checks passed
@teunbrand teunbrand deleted the guide_circles_multilayer branch February 17, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interaction between guide_circles and geom_smooth
1 participant