-
Notifications
You must be signed in to change notification settings - Fork 4
parse JSON export akin to HTML export #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Current quick-fix logs errors (last two lines of this log): |
|
The JSON should be parsed now, but I haven't looked into why the file is not downloading. I'll take a look later. |
johanhoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uncertain why file fails to download... need to debug now.
| else { | ||
| Textile.parseJson(zip); | ||
| } | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added switch in Textile.parseZip
| } | ||
| }); | ||
| return true | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add reusable function called Textile.parseZipMap
⌛️Use Textile.parseZipMap in Textile.parseJson
⏳Reuse Textile.parseZipMap in Textile.parseHtml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we "Don't repeat ourselves", we could reuse our new parseZipMap function in parseHtml, but that may call for a separate pull request with separate testing.
You can accept this PR without a decision on this.
| Textile.addDownload(); | ||
| }); | ||
| }); | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⌛️Add new JSON functionality to Textile.parseJson
|
Okay "it works". When I unzip the download, I get this: However, I am ashamed to see now two things....
Constructive Feedback for TextileA pro tip for 2019In terms of organization, you get "the same thing" by:
The solution for 2020Well, I came to
Questions? |
|
Hey! Sorry for the delayed response. Awesome work + feedback. I'm thinking of adding a continuous exporter example that you can run on your desktop. I'll take what you learned here (2020) to help guide that for sure |

I'll try to parse JSON exports, as said in Issue #10.
This PR is now ready, pending tests and approval.
.parseZip.parseHtml.parseJson.parseZipMap.parseZipMapin.parseJson.parseZipMapin.parseHtml