Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions/checkoutのバージョンコメントを厳密にする #165

Closed
wants to merge 1 commit into from

Conversation

massongit
Copy link
Contributor

@massongit massongit commented Dec 11, 2024

Actionsのバージョンコメントを曖昧な形で記述していると、renovateによるマイナー・パッチアップデートのPRでバージョンが記載されないので分かりづらいです: #160
そのため、 actions/checkout のバージョンコメントを厳密にすることで、renovateによるアップデートPRでバージョンが記載されるようにします。

Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: d6d0d06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@azu
Copy link
Member

azu commented Dec 14, 2024

これrenovateのバグでshaになったので、shaをやめて単純なバージョン指定でもいいかなとおもました。(そこまでセンシティブにpinする必要性もないので)
https://github.com/features/preview/immutable-actions が使えるようになったら、こっちに移行してshaは使わなくなると思います

@massongit
Copy link
Contributor Author

なるほど。
では一旦こちらはcloseします。

@massongit massongit closed this Dec 14, 2024
@massongit massongit deleted the fix_version branch December 14, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants