add test coverage for go proxy (#460)

* add coverage for go proxy * Refactor CLI flag name for allowed proxy addresses
tg123 · Oct 18, 2024 · 4ad8e77 · 4ad8e77
1 parent e6388b6
commit 4ad8e77
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/cmd/sshpiperd/main.go b/cmd/sshpiperd/main.go
@@ -173,9 +173,10 @@ func main() {
 				EnvVars: []string{"SSHPIPERD_DROP_HOSTKEYS_MESSAGE"},
 			},
 			&cli.StringSliceFlag{
-				Name:  "allowed-proxy-addresses",
-				Value: cli.NewStringSlice(),
-				Usage: "allowed proxy addresses, only connections from these ip ranges are allowed to send a proxy header based on the PROXY protocol, empty will disable the PROXY protocol support",
+				Name:    "allowed-proxy-addresses",
+				Value:   cli.NewStringSlice(),
+				Usage:   "allowed proxy addresses, only connections from these ip ranges are allowed to send a proxy header based on the PROXY protocol, empty will disable the PROXY protocol support",
+				EnvVars: []string{"SSHPIPERD_ALLOWED_PROXY_ADDRESSES"},
 			},
 		},
 		Action: func(ctx *cli.Context) error {

diff --git a/e2e/docker-compose.yml b/e2e/docker-compose.yml
@@ -83,6 +83,7 @@ services:
       - SSHPIPERD_LOG_LEVEL=trace
       - SSHPIPERD_E2E_TEST=1
       - SSHPIPERD_DEBUG=${SSHPIPERD_DEBUG}
+      - SSHPIPERD_ALLOWED_PROXY_ADDRESSES=0.0.0.0/0
       - DOCKER_API_VERSION=1.40
     build: 
       context: ../