Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TGMC Q1 2025 TGUI bump/516 compat #17054

Open
wants to merge 66 commits into
base: master
Choose a base branch
from

Conversation

TiviPlus
Copy link
Member

@TiviPlus TiviPlus commented Feb 8, 2025

REPORT ISSUES IF YOU HAVE THEM

About The Pull Request

Mega size PR to bring us up to speed on TGUI and maybe get us working on 516
ideally the last of this caliber since tgui-core is making a lot of this easier and a lot of this is href/import swapping
CHANGES

  • General
    • We use tgui-core (centralized tgui component library now). all components have been deleted from the repo to use this instead
    • added a bunch of 516 compat features (dm and tgui side) while i cant test locally this may means it works in prod now. also includes a warning for people on 516
    • updated fontawesome to latest, added new file with all the possible icons and a unit test for generation
    • since uselocalstate is also deprecated, changes a bunch of UIs to use usestate now
    • fixed a bunch of sassy css warnings/errors etc and brought us up to speed
    • tgui should build faster, and updated a bunch of related build tooling. also added some low memory mode commands
    • fontawesome is updated, and now lists all included icons as part of a unit test
    • updated asset cache, it also caches spritesheets now
    • tests should also run on 516 now
    • fixed dev server not working sometimes
  • Chat
    • Fixed realiability subsystem, messages shouldnt get dropped now
    • tsxed
    • stat panel now looks fancier and tgui-like
    • chat indicators will also now detect when a user is typing in the command bar (needs non tgui ui update pr)
    • typing indicator now has an associated trait
    • updated play-internet-sound to show more info about the song (link, who played it, author etc)
    • you can upload custom fonts to use with the chat now
    • you can set the style of the stat panel now
    • Removed the limit on chat highlights. it will instead warn you when you go over the limit about performance

God knows what else

I DID NOT TEST CAMPAIGN UIS ONLY MOST IMPORTANT XVH UIS

Non exhaustive Relevant TG PRs

tgstation/tgstation#83364
tgstation/tgstation#82032
tgstation/tgstation#72805
tgstation/tgstation#88648
tgstation/tgstation#88069
tgstation/tgstation#84053
tgstation/tgstation#84448
tgstation/tgstation#82569
tgstation/tgstation#88796
tgstation/tgstation#82334
tgstation/tgstation#81354
tgstation/tgstation#83098
tgstation/tgstation#84601
tgstation/tgstation#82652
tgstation/tgstation#87964
tgstation/tgstation#87763
tgstation/tgstation#82527
tgstation/tgstation#84853
tgstation/tgstation#84035
tgstation/tgstation#88624
tgstation/tgstation#89280
tgstation/tgstation#74573
tgstation/tgstation#89022
tgstation/tgstation#83597
tgstation/tgstation#82714
tgstation/tgstation#81381
tgstation/tgstation#88699
tgstation/tgstation#89316
tgstation/tgstation#88919
tgstation/tgstation#75431
tgstation/tgstation#83081
tgstation/tgstation#78879
tgstation/tgstation#89142
tgstation/tgstation#80522
tgstation/tgstation#83218
tgstation/tgstation#87776
tgstation/tgstation#81913
tgstation/tgstation#82854
tgstation/tgstation#79916
tgstation/tgstation#89380
tgstation/tgstation#89386
tgstation/tgstation#87700
tgstation/tgstation#89363
tgstation/tgstation#89180

Changelog

🆑
add: Added the ability to set custom fonts for the chat
qol: changed a bunch of options to tgchat, e.g you can reorder tabs now
qol: Stat panel looks more tgui like now
qol: you can set a style for the stat panel now
qol: removed limit of chat highlights. it just warns you about performance now
qol: the req menu buy button now turns red when you can't afford the cart
fix: typing in the command bar will be detected by the typing indicator
fix: fixed a tgui bluescreen in the cargo UI
fix: fixed numerous issues with UIs
fix: TGMC clientside may or may not work on 516 now
fix: fixed a number of hrefs to work on 516
imageadd: updated the tgui icon library
code: We now cache spritesheets across rounds
refactor: TGUI now uses the centralized SS13 library
admin: play internet sound will now display (optionally) who played the song and other info such as the link and the artist
code: and many other changes not included in this changelog
/:cl:

@github-actions github-actions bot added the GitHub Changes GitHub related matters. label Feb 10, 2025
@github-actions github-actions bot removed the Merge Conflict Pull request is in a conflicted state with base branch. label Feb 10, 2025
@TiviPlus TiviPlus added Sprites Changes to .dmi file. Merge Conflict Pull request is in a conflicted state with base branch. Fix Fixes an issue with the game. Feature New interesting mechanics with new interesting bugs UI We make things worse, but rounder Quality of Life Minor changes that make the game nicer to play and removed Merge Conflict Pull request is in a conflicted state with base branch. labels Feb 10, 2025
@TiviPlus TiviPlus marked this pull request as ready for review February 10, 2025 13:40
@TiviPlus TiviPlus added the Code Improvement Changes for adhering to code standards and codebase maintainability. label Feb 10, 2025
@ivanmixo ivanmixo added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Feb 10, 2025
@github-actions github-actions bot removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Changes for adhering to code standards and codebase maintainability. Feature New interesting mechanics with new interesting bugs Fix Fixes an issue with the game. GitHub Changes GitHub related matters. Quality of Life Minor changes that make the game nicer to play Sprites Changes to .dmi file. UI We make things worse, but rounder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants