Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to EFCore 9 #2059

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Update to EFCore 9 #2059

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cccde49
Update to EFCore 9
Cyberboss Dec 21, 2024
548d466
Merge branch 'dev' of https://github.com/tgstation/tgstation-server i…
Cyberboss Jan 2, 2025
6391b73
Cleanup IDE messages
Cyberboss Jan 2, 2025
458b09d
Switch back to constants for parameterized collections
Cyberboss Jan 2, 2025
f32a182
Normalize SQLite Model
Cyberboss Jan 2, 2025
b153da5
Merge branch 'dev' of https://github.com/tgstation/tgstation-server i…
Cyberboss Jan 2, 2025
8d9bb24
Fix build error
Cyberboss Jan 2, 2025
66b8d57
Fix migration tests issues
Cyberboss Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tgstation.Server.Host/.config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"dotnet-ef": {
"version": "8.0.11",
"version": "9.0.0",
"commands": [
"dotnet-ef"
]
Expand Down
2 changes: 1 addition & 1 deletion src/Tgstation.Server.Host/Database/Design/MySqlDesignTimeDbContextFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ sealed class MySqlDesignTimeDbContextFactory : IDesignTimeDbContextFactory<MySql
{
/// <inheritdoc />
public MySqlDatabaseContext CreateDbContext(string[] args)
=> new MySqlDatabaseContext(
=> new(
DesignTimeDbContextFactoryHelpers.CreateDatabaseContextOptions<MySqlDatabaseContext>(
DatabaseType.MariaDB,
"Server=127.0.0.1;User Id=root;Password=zdxfOOTlQFnklwzytzCj;Database=TGS_Design"));
Expand Down
1 change: 1 addition & 0 deletions src/Tgstation.Server.Host/Database/MySqlDatabaseContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ public static void ConfigureWith(DbContextOptionsBuilder options, DatabaseConfig
serverVersion,
mySqlOptions =>
{
mySqlOptions.TranslateParameterizedCollectionsToConstants();
mySqlOptions.EnableRetryOnFailure();
mySqlOptions.UseQuerySplittingBehavior(QuerySplittingBehavior.SingleQuery);
});
Expand Down
1 change: 1 addition & 0 deletions src/Tgstation.Server.Host/Database/PostgresSqlDatabaseContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public static void ConfigureWith(DbContextOptionsBuilder options, DatabaseConfig
AppContext.SetSwitch("Npgsql.EnableLegacyTimestampBehavior", true);
options.UseNpgsql(databaseConfiguration.ConnectionString, options =>
{
options.TranslateParameterizedCollectionsToConstants();
options.EnableRetryOnFailure();
options.UseQuerySplittingBehavior(QuerySplittingBehavior.SingleQuery);

Expand Down
1 change: 1 addition & 0 deletions src/Tgstation.Server.Host/Database/SqlServerDatabaseContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public static void ConfigureWith(DbContextOptionsBuilder options, DatabaseConfig
databaseConfiguration.ConnectionString,
sqlServerOptions =>
{
sqlServerOptions.TranslateParameterizedCollectionsToConstants();
sqlServerOptions.EnableRetryOnFailure();
sqlServerOptions.UseQuerySplittingBehavior(QuerySplittingBehavior.SingleQuery);
});
Expand Down
6 changes: 5 additions & 1 deletion src/Tgstation.Server.Host/Database/SqliteDatabaseContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ public static void ConfigureWith(
if (databaseConfiguration.DatabaseType != DatabaseType.Sqlite)
throw new InvalidOperationException($"Invalid DatabaseType for {nameof(SqliteDatabaseContext)}!");

options.UseSqlite(databaseConfiguration.ConnectionString, sqliteOptions => sqliteOptions.UseQuerySplittingBehavior(QuerySplittingBehavior.SingleQuery));
options.UseSqlite(databaseConfiguration.ConnectionString, sqliteOptions =>
{
sqliteOptions.TranslateParameterizedCollectionsToConstants();
sqliteOptions.UseQuerySplittingBehavior(QuerySplittingBehavior.SingleQuery);
});
}

/// <inheritdoc />
Expand Down
12 changes: 6 additions & 6 deletions src/Tgstation.Server.Host/Tgstation.Server.Host.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,25 +118,25 @@
<!-- Usage: Generating dumps of dotnet engine processes -->
<PackageReference Include="Microsoft.Diagnostics.NETCore.Client" Version="0.2.553101" />
<!-- Usage: Database ORM -->
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.11" />
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="9.0.0" />
<!-- Usage: Automatic migration generation using command line -->
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="8.0.11">
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="9.0.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<!-- Usage: Sqlite ORM plugin -->
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="8.0.11" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="9.0.0" />
<!-- Usage: MSSQL ORM plugin -->
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.11" />
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="9.0.0" />
<!-- Usage: POSIX support for syscalls, signals, and symlinks -->
<PackageReference Include="Mono.Posix.NETStandard" Version="1.0.0" />
<!-- Usage: Cron string parsing -->
<PackageReference Include="NCrontab.Signed" Version="3.3.3" />
<!-- Usage: YAML config plugin -->
<PackageReference Include="NetEscapades.Configuration.Yaml" Version="3.1.0" />
<!-- Usage: PostgresSQL ORM plugin -->
<PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="8.0.10" />
<PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="9.0.2" />
<!-- Usage: MYSQL/MariaDB ORM plugin -->
<PackageReference Include="Pomelo.EntityFrameworkCore.MySql" Version="8.0.2" />
<PackageReference Include="Pomelo.EntityFrameworkCore.MySql" Version="9.0.0-preview.2.efcore.9.0.0" />
<!-- Usage: Discord interop -->
<PackageReference Include="Remora.Discord" Version="2024.3.0" />
<!-- Usage: Rich logger builder -->
Expand Down
2 changes: 1 addition & 1 deletion tests/Tgstation.Server.Host.Tests/Tgstation.Server.Host.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<ItemGroup>
<!-- Usage: Creating mock database implementations -->
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.11" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
8 changes: 4 additions & 4 deletions tests/Tgstation.Server.Tests/Live/TestLiveServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
Expand Down Expand Up @@ -294,7 +294,7 @@
}
}

[ClassCleanup]
[ClassCleanup(ClassCleanupBehavior.EndOfClass)]
public static void Cleanup()
{
CachingFileDownloader.Cleanup();
Expand All @@ -302,7 +302,7 @@

[TestMethod]
public async Task TestUpdateProtocolAndDisabledOAuth()
{

Check failure on line 305 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Advanced, Release)

TestUpdateProtocolAndDisabledOAuth 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestUpdateProtocolAndDisabledOAuth threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 305 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Advanced, Debug)

TestUpdateProtocolAndDisabledOAuth 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestUpdateProtocolAndDisabledOAuth threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 305 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Basic, Release)

TestUpdateProtocolAndDisabledOAuth 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestUpdateProtocolAndDisabledOAuth threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 305 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Basic, Debug)

TestUpdateProtocolAndDisabledOAuth 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestUpdateProtocolAndDisabledOAuth threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.
using var server = new LiveTestingServer(null, false);
using var serverCts = new CancellationTokenSource();
var cancellationToken = serverCts.Token;
Expand Down Expand Up @@ -466,7 +466,7 @@

[TestMethod]
public async Task TestUpdateBadVersion()
{

Check failure on line 469 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Advanced, Release)

TestUpdateBadVersion 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestUpdateBadVersion threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 469 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Advanced, Debug)

TestUpdateBadVersion 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestUpdateBadVersion threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 469 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Basic, Release)

TestUpdateBadVersion 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestUpdateBadVersion threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 469 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Basic, Debug)

TestUpdateBadVersion 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestUpdateBadVersion threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.
using var server = new LiveTestingServer(null, false);
using var serverCts = new CancellationTokenSource();
var cancellationToken = serverCts.Token;
Expand Down Expand Up @@ -503,7 +503,7 @@

[TestMethod]
public async Task TestOneServerSwarmUpdate()
{

Check failure on line 506 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Advanced, Release)

TestOneServerSwarmUpdate 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestOneServerSwarmUpdate threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 506 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Advanced, Debug)

TestOneServerSwarmUpdate 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestOneServerSwarmUpdate threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 506 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Basic, Release)

TestOneServerSwarmUpdate 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestOneServerSwarmUpdate threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 506 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Basic, Debug)

TestOneServerSwarmUpdate 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestOneServerSwarmUpdate threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.
// cleanup existing directories
new LiveTestingServer(null, false).Dispose();

Expand Down Expand Up @@ -597,7 +597,7 @@

[TestMethod]
public async Task TestSwarmSynchronizationAndUpdates()
{

Check failure on line 600 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Advanced, Release)

TestSwarmSynchronizationAndUpdates 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestSwarmSynchronizationAndUpdates threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 600 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Advanced, Debug)

TestSwarmSynchronizationAndUpdates 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestSwarmSynchronizationAndUpdates threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 600 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Basic, Release)

TestSwarmSynchronizationAndUpdates 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestSwarmSynchronizationAndUpdates threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 600 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Basic, Debug)

TestSwarmSynchronizationAndUpdates 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestSwarmSynchronizationAndUpdates threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.
// cleanup existing directories
new LiveTestingServer(null, false).Dispose();
const string PrivateKey = "adlfj73ywifhks7iwrgfegjs";
Expand Down Expand Up @@ -874,7 +874,7 @@

[TestMethod]
public async Task TestSwarmReconnection()
{

Check failure on line 877 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Advanced, Release)

TestSwarmReconnection 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestSwarmReconnection threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 877 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Advanced, Debug)

TestSwarmReconnection 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestSwarmReconnection threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 877 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Basic, Release)

TestSwarmReconnection 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestSwarmReconnection threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.

Check failure on line 877 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Basic, Debug)

TestSwarmReconnection 

Test method Tgstation.Server.Tests.Live.TestLiveServer.TestSwarmReconnection threw exception: 
System.InvalidOperationException: An error was generated for warning 'Microsoft.EntityFrameworkCore.Migrations.PendingModelChangesWarning': The model for context 'SqliteDatabaseContext' has pending changes. Add a new migration before updating the database. This exception can be suppressed or logged by passing event ID 'RelationalEventId.PendingModelChangesWarning' to the 'ConfigureWarnings' method in 'DbContext.OnConfiguring' or 'AddDbContext'.
// cleanup existing directories
new LiveTestingServer(null, false).Dispose();

Expand Down Expand Up @@ -1356,7 +1356,7 @@
{
Console.WriteLine($"ADDITIONAL TEST ERROR: {ex}");
}
}

Check failure on line 1359 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Advanced, Release)

TestStandardTgsOperation 

TGS ERR: Instance manager startup error!

Check failure on line 1359 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Advanced, Debug)

TestStandardTgsOperation 

TGS ERR: Instance manager startup error!

Check failure on line 1359 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Basic, Release)

TestStandardTgsOperation 

TGS ERR: Instance manager startup error!

Check failure on line 1359 in tests/Tgstation.Server.Tests/Live/TestLiveServer.cs

View workflow job for this annotation

GitHub Actions / CI Pipeline / Linux Live Tests (Sqlite, Basic, Debug)

TestStandardTgsOperation 

TGS ERR: Instance manager startup error!
}
else
await internalTask;
Expand Down Expand Up @@ -1751,7 +1751,7 @@
}
catch (SocketException ex)
{
Assert.AreEqual(ex.SocketErrorCode, SocketError.AddressAlreadyInUse);
Assert.AreEqual(SocketError.AddressAlreadyInUse, ex.SocketErrorCode);
}
finally
{
Expand Down Expand Up @@ -1897,7 +1897,7 @@
expectedCompileJobId = compileJob.Id.Value;
dd = await wdt.TellWorldToReboot(true, cancellationToken);

Assert.AreEqual(dd.ActiveCompileJob.Job.Id, expectedCompileJobId);
Assert.AreEqual(expectedCompileJobId, dd.ActiveCompileJob.Job.Id);
Assert.AreEqual(WatchdogStatus.Online, dd.Status.Value);

expectedCompileJobId = dd.ActiveCompileJob.Id.Value;
Expand Down
Loading