Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployed code #2

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

alexanderghose
Copy link

hey doug, first of all, it works right now! However, unfortunately i hadn't pulled your latest stuff, but had started hacking away until the thing did what i needed. So i think this is way, way, way less elegant and significantly more hacky than what you currently have, and previously had, but ended up getting the job done.

Also due to node_modules being gitignored, one fix that isn't visible in the code that i'm currently using for the tracker is this one here, which involved modifying the mailparser.sj file in mailparser in the node_modules directly: jcreigno/nodejs-mail-notifier#43 (comment)

I'd encourage you not to accept this pull request due to how hacky it is, or .. if you did, to put it into a small branch somewhere. Thank you again for all of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant