improve logic forward

thanhdanh27600 · Oct 23, 2023 · d021361 · d021361
1 parent 768dbec
commit d021361
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/src/components/screens/URLTracking/index.tsx b/src/components/screens/URLTracking/index.tsx
@@ -30,7 +30,7 @@ export const URLTracking = ({ hash }: { hash: string }) => {
           <div className="mt-8">
             <ShortenUrlTile />
             <URLShare />
-            <URLAdvancedSetting defaultOpen={false} shortenUrl={shortenUrl} />
+            <URLAdvancedSetting />
           </div>
           <div className="m-4">
             <FeedbackLink template={FeedbackTemplate.URL_TRACKING} />

diff --git a/src/components/sections/NoteInput.tsx b/src/components/sections/NoteInput.tsx
@@ -197,7 +197,7 @@ export const NoteInput = () => {
         className="mx-auto mt-4 flex w-fit min-w-[5rem] justify-center"
         animation
       />
-      {hasNote && <URLAdvancedSetting defaultOpen={false} />}
+      {hasNote && <URLAdvancedSetting />}
       <FeedbackLink template={FeedbackTemplate.NOTE} />
     </div>
   );

diff --git a/src/components/sections/URLAdvancedSetting.tsx b/src/components/sections/URLAdvancedSetting.tsx
@@ -37,7 +37,7 @@ const tabs: Tab[] = [
   },
 ];
 
-export const URLAdvancedSetting = ({ defaultOpen = true }: { defaultOpen?: boolean; shortenUrl?: string }) => {
+export const URLAdvancedSetting = () => {
   const { t, locale } = useTrans();
   const [selectedKey, setSelectedKey] = useState(tabs[0]?.key);
 
@@ -51,7 +51,7 @@ export const URLAdvancedSetting = ({ defaultOpen = true }: { defaultOpen?: boole
   );
 
   return (
-    <Accordion title={title} defaultOpen={defaultOpen} className="my-4">
+    <Accordion title={title} className="my-4">
       <div>
         <div className="my-4" />
         <Tabs tabs={tabs} selectedKey={selectedKey} setSelectedKey={setSelectedKey} />

diff --git a/src/services/cache/shorten.service.ts b/src/services/cache/shorten.service.ts
@@ -35,11 +35,10 @@ export class ShortenCache {
     return await redis.hexists(hashKey, 'url');
   }
   async postShortenHash(history: UrlShortenerHistory) {
-    let rs: string[] = [];
+    let data: string[] = [];
     Object.entries(history).forEach((cur) => {
-      if (cur[1]) rs.push(cur[0], cur[1].toString());
+      if (cur[1]) data.push(cur[0], cur[1].toString());
     });
-    const data = [...rs, 'updatedAt', new Date().getTime()];
     const hashKey = getRedisKey(REDIS_KEY.MAP_SHORTEN_BY_HASH, history.hash);
     await Promise.all([redis.hset(hashKey, data), redis.expire(hashKey, LIMIT_SHORTENED_SECOND)]);
   }