Skip to content

Conversation

@thatsacrylic
Copy link
Owner

Summary

  • clone the Cosmos repository during CI and build it with make
  • ensure the Cosmos toolchain installation runs before restoring and building the solution

Testing

  • not run (workflow-only change)

https://chatgpt.com/codex/tasks/task_e_68f7b1c4c354832984a988e757e2b27c

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +22 to +32
- name: Build Cosmos toolchain
run: |
git clone https://github.com/CosmosOS/Cosmos.git
pushd Cosmos
make
popd

- name: Set up .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: 6.0.x

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Build Cosmos toolchain before installing .NET CLI

The workflow runs make to build the Cosmos toolchain before the .NET SDK is installed. Cosmos’s makefile invokes the dotnet CLI to restore and build its components, so on a fresh ubuntu-latest runner this step will fail with dotnet: command not found and the entire job aborts before your project is built. The .NET setup step needs to precede the toolchain build so that the required CLI is available.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants