add unexported symvec2string and braces kwarg to `prettyprint_sym…

…metryvector`

Project.toml

@@ -1,7 +1,7 @@
 name = "Crystalline"
 uuid = "ae5e2be0-a263-11e9-351e-f94dad1eb351"
 authors = ["Thomas Christensen <tchr@mit.edu>"]
-version = "0.3.6"
+version = "0.3.7"
 
 [deps]
 Combinatorics = "861a8166-3701-5b0c-9a16-15d98fcdc6aa"

src/show.jl

@@ -319,14 +319,19 @@ end
 
 
 # --- BandRep ---
-function prettyprint_symmetryvector(io::IO, irvec::AbstractVector{<:Real}, irlabs::Vector{String})
+function prettyprint_symmetryvector(
+            io::IO, 
+            irvec::AbstractVector{<:Real},
+            irlabs::Vector{String};
+            braces::Bool=true)
+
     Nⁱʳʳ  = length(irlabs)
     Nⁱʳʳ′ = length(irvec) 
     if !(Nⁱʳʳ′ == Nⁱʳʳ || Nⁱʳʳ′ == Nⁱʳʳ+1)
         # we allow irvec to exceed the dimension of irlabs by 1, in case it includes dim(BR)
         throw(DimensionMismatch("irvec and irlabs must have matching dimensions"))
     end
-    print(io, '[')
+    braces && print(io, '[')
 
     first_nz   = true
     group_klab = klabel(first(irlabs))
@@ -358,9 +363,15 @@ function prettyprint_symmetryvector(io::IO, irvec::AbstractVector{<:Real}, irlab
                 print(io, absc)
             end
         end
-        print(io, irlab)      
+        print(io, irlab)
     end
-    print(io, ']')
+    braces && print(io, ']')
+end
+function symvec2string(irvec::AbstractVector{<:Real}, irlabs::Vector{String}; 
+            braces::Bool=true)
+    io = IOBuffer()
+    prettyprint_symmetryvector(io, irvec, irlabs; braces=braces)
+    return String(take!(io))
 end
 
 summary(io::IO, BR::BandRep) = print(io, dim(BR), "-band BandRep (", label(BR), " at ", wyck(BR), ")")

src/symeigs2irrep.jl

@@ -92,7 +92,7 @@ function find_representation(symvals::AbstractVector{<:Number},
     # check that imaginary part is numerically zero and that all entries are representible
     # in type assert_return_T
     msℝ = real.(ms)
-    if !isapprox(msℝ, ms,  atol=atol)
+    if !isapprox(msℝ, ms, atol=atol)
         if verbose 
             @info """non-negligible imaginary components found in irrep multicity; returning
                      `nothing` as sentinel""" maximum(imag, ms)
@@ -114,6 +114,9 @@ function find_representation(symvals::AbstractVector{<:Number},
         end
 
     elseif assert_return_T <: AbstractFloat
+        # TODO: not sure why we wouldn't want to check for `atol` distance from nearest
+        #       integer here (returning `nothing` in the negative case) - should check if
+        #       we ever actually rely on this
         return convert.(assert_return_T, msℝ)
     end