You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The styleProps generator was converting Figma's TextCase values to CSS by lowercasing values other than ORIGINAL, resulting in invalid CSS values for text-transform like upper (rather than uppercase). This fixes that conversion by adding a utility function to properly map TextCase values to CSS values.
The `styleProps` generator was converting [Figma's `TextCase`
values](https://www.figma.com/plugin-docs/api/TextCase/) to
CSS by lowercasing values other than `ORIGINAL`, resulting in invalid
CSS values like `upper` (rather than `uppercase`). This fixes that
conversion by adding a utility function to properly map `TextCase`
values to CSS values.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I wrote this up as I was investigating what was causing #113 so I figured I would just put it in and if it's helpful, great! I'm happy to make any tweaks you'd like or for you to take it over and do what you will with it. Hope this isn't an annoyance to you all. Love the plugin — we're in the process of trying to adopt it more systematically on my team ❤️
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
stylePropsgenerator was converting Figma'sTextCasevalues to CSS by lowercasing values other thanORIGINAL, resulting in invalid CSS values fortext-transformlikeupper(rather thanuppercase). This fixes that conversion by adding a utility function to properly mapTextCasevalues to CSS values.Find a simple reproduction here. This is a proposed fix for #113