Bugfix: Attempt to read property "smimeSigned" on null

the-djmaze · Aug 12, 2024 · 486bbba · 486bbba
1 parent 55d7d52
commit 486bbba
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/snappymail/v/0.0.0/app/libraries/RainLoop/Actions/Messages.php b/snappymail/v/0.0.0/app/libraries/RainLoop/Actions/Messages.php
@@ -480,6 +480,9 @@ public function DoMessage() : array
 		try
 		{
 			$oMessage = $this->MailClient()->Message($sFolder, $iUid, true, $this->Cacher($oAccount));
+			if (!$oMessage) {
+				throw new \RuntimeException('Message not found');
+			}
 
 			$bAutoVerify = $this->Config()->Get('security', 'auto_verify_signatures', false);
 
@@ -572,13 +575,10 @@ public function DoMessage() : array
 			throw new ClientException(Notifications::CantGetMessage, $oException);
 		}
 
-		if ($oMessage) {
-			$ETag = $oMessage->ETag($this->getAccountFromToken()->ImapUser());
-			$this->verifyCacheByKey($ETag);
-			$this->Plugins()->RunHook('filter.result-message', array($oMessage));
-			$this->cacheByKey($ETag);
-		}
-
+		$ETag = $oMessage->ETag($this->getAccountFromToken()->ImapUser());
+		$this->verifyCacheByKey($ETag);
+		$this->Plugins()->RunHook('filter.result-message', array($oMessage));
+		$this->cacheByKey($ETag);
 		return $this->DefaultResponse($oMessage);
 	}