Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display ICS preview using an ICS library #1745

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

PhieF
Copy link

@PhieF PhieF commented Sep 12, 2024

Hi

Current implementation of the ICS plugin is a bit messy, as you can see in this screenshot

365719204-3aba63e5-fdb6-4eea-9a06-dbaa8838beec

So we've re-implemented it using this library
https://github.com/kewisch/ical.js

and here is the result with the same file

366458907-3e753d8c-ae38-4ea1-ba60-a2c7ce694cae

What would you think of that ?

Thanks !

@the-djmaze
Copy link
Owner

the-djmaze commented Sep 14, 2024

Looks nice!
Could you create it as a new extension/plugin?

@PhieF
Copy link
Author

PhieF commented Sep 17, 2024

@the-djmaze thanks for the review, all done !

@the-djmaze the-djmaze merged commit 02ef7c8 into the-djmaze:master Sep 17, 2024
@the-djmaze
Copy link
Owner

the-djmaze commented Sep 17, 2024

Thanks!

Since there are 3 ICS parsers now (yours, mine and Nextcloud extension).
I will put some parse code in the SnappyMail base code.
Mainly because the MS Windows timezones conversion to IANA could be handy anytime.

I will update your plugin when available 😉

@PhieF
Copy link
Author

PhieF commented Sep 18, 2024

perfect, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants