Try to reduce usage of any in the codebase
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s if possible or otherwise ignore them with a comment of why they are ignored
MTRNord
commented
Oct 14, 2023
| @@ -213,7 +213,8 @@ async function execSinceCommandAux(destinationRoomId: string, event: any, mjolni | |||
| } else if (maybeRoom.startsWith("#") || maybeRoom.startsWith("!")) { | |||
| const roomId = await mjolnir.client.resolveRoom(maybeRoom); | |||
| if (!protectedRooms.has(roomId)) { | |||
| return mjolnir.managementRoomOutput.logMessage(LogLevel.WARN, "SinceCommand", `This room is not protected: ${htmlEscape(roomId)}.`); | |||
There was a problem hiding this comment.
This was found as a result of the any return type of logMessage. I fixed it with what I assume may have been intended here. But logMessage can only return void. So the return made no selve (and now causes a typescript error as it should)
|
I don't think this fundamentally changes anything. I know that having to manually disable the check would stop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes the usage of
anybe a linter error by default. In most cases, we likely don't wantany. Most usages that currently exist seem to be frommatrix-bot-sdk. Some are from nodejs itself.