Initial MSC1929 Implementation #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
MTRNord
force-pushed
the
MTRNord/MSC1929
branch
from
962c5ba
to
97fcdb9
Compare
MTRNord
force-pushed
the
MTRNord/MSC1929
branch
from
f32b211
to
8a888e2
Compare
Gnuxie
reviewed
Oct 27, 2023
|
|
||
| try { | ||
| const resp: SupportJson = await new Promise((resolve, reject) => { | ||
| getRequestFn()(`${domain}/.well-known/matrix/support`, (error: any, response: any, resBody: unknown) => { |
There was a problem hiding this comment.
what did i do wrong here? do they just not support the MSC?
There was a problem hiding this comment.
Ah Hm ok yeah it prints the error but seems like in this case it just printed the whole page oO. Yeah not supported and it went wrong.
…s for the representation type. Co-authored-by: gnuxie <Gnuxie@protonmail.com>
|
N.B. We updated the MSC with a few name changes here and there, you might want to update to reflect changes. |
I will take a look. I think I already applied the comments before the MSC did :) Thanks for the notice however! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command to query the MSC1929 JSON and display it. It also adds tests for this.
Some example output:
All infos available:
Only users available:
Only Support page available: