Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding get_columns method to all custom tables #3515

Merged

Conversation

dpanta94
Copy link
Member

@dpanta94 dpanta94 commented Jan 30, 2025

🎫 Ticket

ETP-956

πŸ—’οΈ Description

Simply adding methods to our custom tables that the updated Abstract requires here

These changes are backwards compatible since the Abstract is not released yet. Will be released along with the Waitlist feature.

No need for changelog this is part of the waitlist feature.

πŸŽ₯ Artifacts

βœ”οΈ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@dpanta94 dpanta94 force-pushed the feat/adding-get_columns-method-to-all-custom-tables branch from 1b60e7e to e002c1d Compare January 30, 2025 14:59
@dpanta94 dpanta94 requested a review from a team January 30, 2025 20:03
@dpanta94 dpanta94 added the code review Status: requires a code review. label Jan 30, 2025
@dpanta94 dpanta94 self-assigned this Jan 30, 2025
@dpanta94 dpanta94 marked this pull request as ready for review January 30, 2025 20:04
@dpanta94 dpanta94 merged commit a4b30a4 into bucket/waitlists Jan 30, 2025
20 of 21 checks passed
@dpanta94 dpanta94 deleted the feat/adding-get_columns-method-to-all-custom-tables branch January 30, 2025 20:13
@dpanta94 dpanta94 removed the code review Status: requires a code review. label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants