Telemetry plugin with exports for OTLP, Jaeger and Datadog #846
release.yaml
on: pull_request
dockerize
4m 35s
compile wasm (cloudflare-worker)
37s
config-schema
7s
Matrix: binary
Annotations
4 errors and 12 warnings
compile wasm (cloudflare-worker)
Process completed with exit code 1.
|
compile binary (x86_64-unknown-linux-gnu)
Process completed with exit code 101.
|
compile binary (aarch64-unknown-linux-gnu)
The operation was canceled.
|
dockerize
buildx bake failed with: ERROR: failed to solve: process "/bin/sh -c cargo build --release --bin conductor" did not complete successfully: exit code: 101
|
this expression creates a reference which is immediately dereferenced by the compiler:
bin/conductor/src/minitrace_actix.rs#L51
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> bin/conductor/src/minitrace_actix.rs:51:70
|
51 | let mut properties: Vec<(&str, String)> = build_request_properties(&req);
| ^^^^ help: change this to: `req`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
unnecessary map of the identity function:
bin/cloudflare_worker/src/lib.rs#L144
warning: unnecessary map of the identity function
--> bin/cloudflare_worker/src/lib.rs:144:12
|
144 | }
| ____________^
145 | | .map(|r| r)
| |_____________________^ help: remove the call to `map`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
= note: `#[warn(clippy::map_identity)]` on by default
|
using `clone` on type `Duration` which implements the `Copy` trait:
libs/engine/src/source/federation_source.rs#L121
warning: using `clone` on type `Duration` which implements the `Copy` trait
--> libs/engine/src/source/federation_source.rs:121:30
|
121 | let interval_spawn = interval.clone();
| ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*interval`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
unneeded `return` statement:
libs/engine/src/gateway.rs#L301
warning: unneeded `return` statement
--> libs/engine/src/gateway.rs:301:9
|
301 | / return ConductorHttpResponse {
302 | | body: GraphQLResponse::new_error("failed to extract GraphQL request from HTTP request")
303 | | .into(),
304 | | status: StatusCode::BAD_REQUEST,
305 | | headers: Default::default(),
306 | | };
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
301 ~ ConductorHttpResponse {
302 + body: GraphQLResponse::new_error("failed to extract GraphQL request from HTTP request")
303 + .into(),
304 + status: StatusCode::BAD_REQUEST,
305 + headers: Default::default(),
306 ~ }
|
|
use of `default` to create a unit struct:
libs/minitrace_reqwest/src/lib.rs#L127
warning: use of `default` to create a unit struct
--> libs/minitrace_reqwest/src/lib.rs:127:37
|
127 | .with(MinitraceReqwestMiddleware::default())
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
plugins/opentelemetry/src/plugin.rs#L91
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> plugins/opentelemetry/src/plugin.rs:91:72
|
91 | let reporter = Self::compose_reporter(&self.config.service_name, &target)
| ^^^^^^^ help: change this to: `target`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
using `clone` on type `SocketAddr` which implements the `Copy` trait:
plugins/opentelemetry/src/plugin.rs#L43
warning: using `clone` on type `SocketAddr` which implements the `Copy` trait
--> plugins/opentelemetry/src/plugin.rs:43:11
|
43 | agent_endpoint.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*agent_endpoint`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `SocketAddr` which implements the `Copy` trait:
plugins/opentelemetry/src/plugin.rs#L38
warning: using `clone` on type `SocketAddr` which implements the `Copy` trait
--> plugins/opentelemetry/src/plugin.rs:38:9
|
38 | endpoint.clone(),
| ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*endpoint`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
length comparison to zero:
libs/tracing/src/otel_utils.rs#L50
warning: length comparison to zero
--> libs/tracing/src/otel_utils.rs:50:6
|
50 | if errors.len() > 0 {
| ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!errors.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
|
use of `or_insert_with` to construct default value:
libs/tracing/src/minitrace_mgr.rs#L76
warning: use of `or_insert_with` to construct default value
--> libs/tracing/src/minitrace_mgr.rs:76:39
|
76 | let chunk = chunks.entry(key).or_insert_with(Vec::new);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `#[warn(clippy::unwrap_or_default)]` on by default
|
you should consider adding a `Default` implementation for `MinitraceManager`:
libs/tracing/src/minitrace_mgr.rs#L16
warning: you should consider adding a `Default` implementation for `MinitraceManager`
--> libs/tracing/src/minitrace_mgr.rs:16:3
|
16 | / pub fn new() -> Self {
17 | | Self {
18 | | reporters: HashMap::new(),
19 | | }
20 | | }
| |___^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
15 + impl Default for MinitraceManager {
16 + fn default() -> Self {
17 + Self::new()
18 + }
19 + }
|
|
compile binary (aarch64-unknown-linux-gnu)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
conductor.schema.json
Expired
|
13.8 KB |
|