Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update rust crate regex to 1.10.3 #348

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 21, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
regex dependencies patch 1.10.2 -> 1.10.3

Release Notes

rust-lang/regex (regex)

v1.10.3

Compare Source

===================
This is a new patch release that fixes the feature configuration of optional
dependencies, and fixes an unsound use of bounds check elision.

Bug fixes:

  • BUG #​1147:
    Set default-features=false for the memchr and aho-corasick dependencies.
  • BUG #​1154:
    Fix unsound bounds check elision.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

🚨 Rust Panic Audit: 108 Potential Panic Points Detected 🚨

Crate: federation_query_planner

📊 Total Usages: 50

  • 🔢 array_index usages: 10
  • 🚨 panic usages: 3
  • 🔎 expect usages: 8
  • 🎁 unwrap usages: 29

Crate: jwt_auth

📊 Total Usages: 45

  • 🎁 unwrap usages: 43
  • 🔢 array_index usages: 2

📌 Expected Annotations

  •     let client = wasm_polyfills::create_http_client().build().unwrap();: // @expected: if initiating an http client fails, then we have to exit.
    

Crate: engine

📊 Total Usages: 10

  • 🎁 unwrap usages: 6
  • 🔎 expect usages: 1
  • 🚨 panic usages: 3

📌 Expected Annotations

  •         Err(e) => panic!("failed to construct endpoint: {:?}", e),: // @expected: if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit
    
  • ConductorGateway::execute(request, &gw.routes[0].route_data).await: // @expected: we can safely index here, it's inside a test with constant defined fixtures.
    
  •     panic!(: // @expected: without a fetcher, there's no executor, without an executor, there's no gateway.
    

Crate: vrl

📊 Total Usages: 3

  • 🔢 array_index usages: 3

📌 Expected Annotations

  •     panic!("failed to compile vrl program");: // @expected: if the provided VRL code in the config file can't compile, we have to exit.
    
  •   .expect("can't merge states when `states` is an empty vector!"): // @expected: `states` is a non-user provided variable
    

Crate: wasm_polyfills

📊 Total Usages: 0

Crate: common

📊 Total Usages: 0

📌 Expected Annotations

  • .unwrap(): // @expected: we're parsing a statically defined constant, we know it works ;)
    

Crate: trusted_documents

📊 Total Usages: 0

Crate: http_get

📊 Total Usages: 0

Crate: graphiql

📊 Total Usages: 0

Crate: test-server

📊 Total Usages: 0

Crate: cloudflare_worker

📊 Total Usages: 0

Crate: cors

📊 Total Usages: 0

Crate: config

📊 Total Usages: 0

📌 Expected Annotations

  • .unwrap();: // @expected: statically defined regex pattern, we know it works ;)
  • let raw_contents = read_to_string(file_path).expect("Failed to read config file");: // @expected: 👇
  •   panic!("Failed to interpolate config file, please resolve the above errors");: // @expected: 👇
    
  •   parse_config_from_json(&config_string).expect("Failed to parse JSON config file"): // @expected: 👇
    
  •   parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file"): // @expected: 👇
    
  •     _ => panic!("Unsupported config file extension"),: // @expected: 👇
    
  •   None => panic!("Config file has no extension"),: // @expected: 👇
    
  • .expect("Failed to serialize json schema for config file!");: // @expected: part of development docgen CLI
    
  • .expect("Failed to write the json schema to the file system!");: // @expected: part of development docgen CLI
    

Crate: napi

📊 Total Usages: 0

📌 Expected Annotations

  • panic!("Exited process!"): // @expected: we need this

Crate: conductor

📊 Total Usages: 0

📌 Expected Annotations

  • tracing::subscriber::set_global_default(subscriber).expect("failed to set up the logger");: // @expected: we need to exit the process, if the logger can't be correctly set.
  •   .expect("Failed to modify the log level");: // @expected: we need to exit, if the provided log level in the configuration file is incompaitable.
    
  •   panic!("Failed to initialize gateway: {:?}", e);: // @expected: we need to exit the process, if the provided configuration file is incorrect.
    

Crate: disable_introspection

📊 Total Usages: 0

📌 Expected Annotations

  •       panic!("failed to compile vrl program for disable_introspection plugin");: // @expected: we need to exit the process if our provided VRL condition has incorrect syntax.
    

Crate: match_content_type

📊 Total Usages: 0

Copy link

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata
{
"conductor": {
  "containerimage.config.digest": "sha256:f576a23de12d545b058fb50d0b0be5d9fd5dc8e837c239da7407c90b6020a530",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:ae60bf3a521b0b018c7b49e485904cdce9fd26c62a3c48e99e2f01c9ad1634ab",
    "size": 902,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:ae60bf3a521b0b018c7b49e485904cdce9fd26c62a3c48e99e2f01c9ad1634ab",
  "image.name": "ghcr.io/the-guild-org/conductor/conductor:d4949d0eed653c31ac787f996a88d83fe2c78027"
}
}

Copy link

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=1.03µs   avg=2.97µs   med=2.38µs   max=586.59µs p(95)=3.3µs   p(99)=5.34µs 
     http_req_connecting............: min=0s       avg=327ns    med=0s       max=469.45µs p(95)=0s      p(99)=0s     
     http_req_duration..............: min=767.89µs avg=991.5µs  med=904.02µs max=31.99ms  p(95)=1.28ms  p(99)=1.74ms 
       { expected_response:true }...: min=767.89µs avg=991.5µs  med=904.02µs max=31.99ms  p(95)=1.28ms  p(99)=1.74ms 
     ✓ { scenario:rps_1000 }........: min=767.89µs avg=991.5µs  med=904.02µs max=31.99ms  p(95)=1.28ms  p(99)=1.74ms 
     http_req_failed................: 0.00%   ✓ 0          ✗ 60001
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0          ✗ 60001
     http_req_receiving.............: min=10.67µs  avg=29.28µs  med=27.59µs  max=1.77ms   p(95)=45.49µs p(99)=55.95µs
     http_req_sending...............: min=6.73µs   avg=16.03µs  med=13.84µs  max=3.97ms   p(95)=29.12µs p(99)=38.35µs
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s       p(95)=0s      p(99)=0s     
     http_req_waiting...............: min=733.63µs avg=946.18µs med=858.36µs max=31.59ms  p(95)=1.23ms  p(99)=1.69ms 
     http_reqs......................: 60001   999.995195/s
     ✓ { scenario:rps_1000 }........: 60001   999.995195/s
     iteration_duration.............: min=844.55µs avg=1.08ms   med=997.21µs max=32.24ms  p(95)=1.37ms  p(99)=1.84ms 
     iterations.....................: 60001   999.995195/s
     ✓ { scenario:rps_1000 }........: 60001   999.995195/s
     valid_graphql_response.........: 100.00% ✓ 60001      ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001      ✗ 0    
     valid_http_code................: 100.00% ✓ 60001      ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001      ✗ 0    
     vus............................: 2       min=0        max=3  
     vus_max........................: 200     min=200      max=200

@dotansimha dotansimha merged commit 7d5c065 into master Jan 22, 2024
13 checks passed
@renovate renovate bot deleted the renovate/regex-1.x branch January 22, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant