Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update actions/cache action to v4 #371

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 24, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/cache action major v3 -> v4

Release Notes

actions/cache (actions/cache)

v4

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

🚨 Rust Panic Audit: 123 Potential Panic Points Detected 🚨

Crate: federation_query_planner

📊 Total Usages: 50

  • 🔢 array_index usages: 10
  • 🔎 expect usages: 8
  • 🎁 unwrap usages: 29
  • 🚨 panic usages: 3

Crate: jwt_auth

📊 Total Usages: 45

  • 🔢 array_index usages: 2
  • 🎁 unwrap usages: 43

📌 Expected Annotations

  •     let client = wasm_polyfills::create_http_client().build().unwrap();: // @expected: if initiating an http client fails, then we have to exit.
    

Crate: engine

📊 Total Usages: 12

  • 🚨 panic usages: 3
  • 🔎 expect usages: 1
  • 🎁 unwrap usages: 8

📌 Expected Annotations

  •     Err(e) => panic!("failed to construct endpoint: {:?}", e),: // @expected: if we are unable to construct the endpoints and attach them onto the gateway's http server, we have to exit
    
  • ConductorGateway::execute(request, &gw.routes[0].route_data).await: // @expected: we can safely index here, it's inside a test with constant defined fixtures.
    
  •     panic!(: // @expected: without a fetcher, there's no executor, without an executor, there's no gateway.
    
  •         panic!("Failed while initializing the executor's fetcher for Federation source");: // @expected: without a fetcher, there's no executor, without an executor, there's no gateway.
    
  •     panic!("Failed while initializing the executor's fetcher for Federation source");: // @expected: without a fetcher, there's no executor, without an executor, there's no gateway.
    

Crate: telemetry

📊 Total Usages: 5

  • 🔢 array_index usages: 3
  • 🎁 unwrap usages: 2

Crate: tracing

📊 Total Usages: 3

  • 🎁 unwrap usages: 3

Crate: conductor

📊 Total Usages: 3

  • 🎁 unwrap usages: 1
  • 🔎 expect usages: 1
  • 🚨 panic usages: 1

📌 Expected Annotations

  •   tracing::subscriber::set_global_default(subscriber).expect("failed to set up tracing");: // @expected: we need to exit the process, if the logger can't be correctly set.
    
  •   panic!("Failed to initialize gateway: {:?}", e);: // @expected: we need to exit the process, if the provided configuration file is incorrect.
    

Crate: vrl

📊 Total Usages: 3

  • 🔢 array_index usages: 3

📌 Expected Annotations

  •     panic!("failed to compile vrl program");: // @expected: if the provided VRL code in the config file can't compile, we have to exit.
    
  •   .expect("can't merge states when `states` is an empty vector!"): // @expected: `states` is a non-user provided variable
    

Crate: config

📊 Total Usages: 1

  • 🚨 panic usages: 1

📌 Expected Annotations

  • .unwrap();: // @expected: statically defined regex pattern, we know it works ;)
  •   panic!("Failed to interpolate config file, please resolve the above errors");: // @expected: 👇
    
  •   parse_config_from_json(&config_string).expect("Failed to parse JSON config file"): // @expected: 👇
    
  •   parse_config_from_yaml(&config_string).expect("Failed to parse YAML config file"): // @expected: 👇
    
  •     _ => panic!("Unsupported config file extension"),: // @expected: 👇
    
  •   None => panic!("Config file has no extension"),: // @expected: 👇
    
  • .expect("Failed to serialize json schema for config file!");: // @expected: part of development docgen CLI
    
  • .expect("Failed to write the json schema to the file system!");: // @expected: part of development docgen CLI
    

Crate: cloudflare_worker

📊 Total Usages: 1

  • 🚨 panic usages: 1

Crate: logger

📊 Total Usages: 0

Crate: common

📊 Total Usages: 0

📌 Expected Annotations

  • .unwrap(): // @expected: we're parsing a statically defined constant, we know it works ;)
    

Crate: cors

📊 Total Usages: 0

Crate: http_get

📊 Total Usages: 0

Crate: wasm_polyfills

📊 Total Usages: 0

Crate: trusted_documents

📊 Total Usages: 0

Crate: disable_introspection

📊 Total Usages: 0

📌 Expected Annotations

  •       panic!("failed to compile vrl program for disable_introspection plugin");: // @expected: we need to exit the process if our provided VRL condition has incorrect syntax.
    

Crate: napi

📊 Total Usages: 0

📌 Expected Annotations

  • panic!("Exited process!"): // @expected: we need this

Crate: match_content_type

📊 Total Usages: 0

Crate: minitrace_reqwest

📊 Total Usages: 0

Crate: graphiql

📊 Total Usages: 0

Crate: test-server

📊 Total Usages: 0

Copy link

🐋 This PR was built and pushed to the following Docker images:

Docker Bake metadata
{
"conductor": {
  "containerimage.config.digest": "sha256:b498e8d46b7a48a94d6357dfb747c3f65871e4fb14ee2951193f6291de867821",
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
    "digest": "sha256:81ff8e151c0123ac6675285cb036075fa90d392780922ba3fdc97a8f2dd77ad1",
    "size": 902,
    "platform": {
      "architecture": "amd64",
      "os": "linux"
    }
  },
  "containerimage.digest": "sha256:81ff8e151c0123ac6675285cb036075fa90d392780922ba3fdc97a8f2dd77ad1",
  "image.name": "ghcr.io/the-guild-org/conductor/conductor:ef285eb282a153536f6950813d6f37e89482a4b3"
}
}

Copy link

✅ Benchmark Results

     data_received..................: 13 MB   221 kB/s
     data_sent......................: 22 MB   363 kB/s
     http_req_blocked...............: min=851ns    avg=2.68µs   med=2.07µs   max=687.6µs  p(95)=3.02µs   p(99)=9.87µs  
     http_req_connecting............: min=0s       avg=309ns    med=0s       max=420.53µs p(95)=0s       p(99)=0s      
     http_req_duration..............: min=309.77µs avg=421.48µs med=376.7µs  max=47.73ms  p(95)=473.55µs p(99)=559.24µs
       { expected_response:true }...: min=309.77µs avg=421.48µs med=376.7µs  max=47.73ms  p(95)=473.55µs p(99)=559.24µs
     ✓ { scenario:rps_1000 }........: min=309.77µs avg=421.48µs med=376.7µs  max=47.73ms  p(95)=473.55µs p(99)=559.24µs
     http_req_failed................: 0.00%   ✓ 0          ✗ 60001
     ✓ { scenario:rps_1000 }........: 0.00%   ✓ 0          ✗ 60001
     http_req_receiving.............: min=9.8µs    avg=25.86µs  med=25.31µs  max=798.66µs p(95)=34.22µs  p(99)=43.83µs 
     http_req_sending...............: min=6.5µs    avg=15.25µs  med=13.91µs  max=1.48ms   p(95)=25.37µs  p(99)=32.78µs 
     http_req_tls_handshaking.......: min=0s       avg=0s       med=0s       max=0s       p(95)=0s       p(99)=0s      
     http_req_waiting...............: min=271.28µs avg=380.36µs med=336.06µs max=47.66ms  p(95)=434.6µs  p(99)=509.8µs 
     http_reqs......................: 60001   999.996298/s
     ✓ { scenario:rps_1000 }........: 60001   999.996298/s
     iteration_duration.............: min=379.97µs avg=507.12µs med=461.38µs max=47.96ms  p(95)=560.7µs  p(99)=684.49µs
     iterations.....................: 60001   999.996298/s
     ✓ { scenario:rps_1000 }........: 60001   999.996298/s
     valid_graphql_response.........: 100.00% ✓ 60001      ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001      ✗ 0    
     valid_http_code................: 100.00% ✓ 60001      ✗ 0    
     ✓ { scenario:rps_1000 }........: 100.00% ✓ 60001      ✗ 0    
     vus............................: 1       min=0        max=2  
     vus_max........................: 200     min=200      max=200

@dotansimha dotansimha merged commit 756a70a into master Jan 25, 2024
16 checks passed
@renovate renovate bot deleted the renovate/actions-cache-4.x branch January 25, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant