Tokyo drift/cleanup #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unused poms--gradle will generate these with proper configuration. * Since I'm going to remove the poms I want to make sure we have parity with the old releases. POMs say com.github.sanctum and com.github.the-h-team, so I'll match it up with the latter for now. (We can't release under sanctum until/unless we get the org slug 'sanctum' (current is 'the-h-team')).
* I think clans-${version} looks cleaner than clans-plugin-${version}. ~~We only use the shadowJar anyway, so it's okay if it overwrites the default jar task.~~
* Disabled the default jar task because we won't use it.
* This stuff never made it to prime time. We'll probably come back to it eventually, but not as-is.
* plus noinspections to silence warn on entrySet forEach, silence spellcheck warn on paste key
* remove redundant method overrides that delegate or mimic their super * use magic constant targets in switch-case
* can be easily turned on/off, just templating for now
* note: disabled compilation + shading of entire cli subproject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.