Implement PvP battles #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am actually surprised how well this works. Everything except necro works perfect already, necro will be a little painful to reverse probably, but also something that is useful despite the garbage code I produced here. In my defense, I absolutely hate how I handeled the construction of the battle turns, but the lib was obviously more about calculating chances then whatever this is... If you have a good idea on how to do that better (especially getting rid of the awful state transfer via these fucking "msg_" prefixed variables) without rewriting the simulation API entirely, I'd love to hear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just dropping this draft here to be sure no work is done twice.
Probably most of this is trash, but maybe there is something useful here.