TVB-2359 New dual brain visualizer for time series #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Adapter for the viewer and html template files.
Add internal template for the 3D brain viewer Merge the js files for the egg viewer into a single js file
- Time Selection syncing the start time with the 3D viewer - Value Inspector - Scrolling Boundaries
f.y_dom should be f.dom_y
two more f.dom_y fixes add interval value
Add increase/decrease button
Transparency for the region activity viewer Highlight selected spheres and display the message of the channel name
Trying to use d3v5
Chrome still doesn't display an overlay (in both the old and new dual viewer)
replace increase/decrease buttons with input fields add animation of the time selection when zoomed in send index number to the 3d slider
only the timeseries plot uses d3 version 5, others use version 3
jump to the next page or jump to the beginning when reaches the end
kimonoki
changed the title
|
To be fixed: |
Update icon for the paused pages Renew the animated_graph.js
while keeping the time selection layout in the 3d Update the d3 version for the svg/d3 viewer
… VS_selectedRegions Unify the function name of creating energy sphere buffers Add blockoverlay for the energy retrieving async calls Avoid redraw the brush when triggering from the input field Add viewer type for the new dual brain viewer TVB-2370 Reset the domain to the last position in the time data
…me selection in the 2d plot
kimonoki
force-pushed
the
new-dual-viewer
branch
from
2e0b706
to
24af584
Compare
Fix syncing when timestep is not one per frame
Add default time selection
…me selection window size is not changed
(wrong region and sphere index) The sphere color is controlled in draw buffer function thus we cannot use selectedRegions in the changeSphereMeasurePoints_energy function
|
bug: in SEEG viewer the channel updated is not sending new request for the energy |
Fix not requesting energy data while updating channel selection
kimonoki
force-pushed
the
new-dual-viewer
branch
from
18a38f1
to
b6e1958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This 2d and 3d viewer is based on the dual brain activity viewer which has these changes:
New class and html templates for the viewer
Rewrote the 2d part in D3.js version 5 and removed the FLOT dependency
Added a time selection bar and input field in the 2d viewer that allows users to select/enter a time range
Zooming, scrolling and play/pause controls in the 2D plot
Add opacity controls for the 3d brain viewer
Display spheres at the region centre or sensor position
When playing the movie while has a valid time selection window, the sizes of the spheres will change according to the energy calculated from that time window (see the PR in the tvb-library repo for the calculation method)
Also included: