Random Quotes and Failed Image Fetching Handling #147
Conversation
|
Quotable has may tags for images so it's not ideal to list them all in the ui, need to think of a future solution. Probably a tag search will be better |
|
I see your PR, I'll see if it can be merged when I have a chance |
|
@the-wright-jamie hi is this going to be merged? |
|
Hopefully. I'm currently working through some long running real life events and I regretfully have not had the time to review recent PRs. I hope to be fully operational again in around 2 weeks time. I understand that this is frustrating, but I appreciate your patience as well as the time and dedication that went into this PR. Please bear with me as I get back up to speed, thank you. |
|
@the-wright-jamie Any update? |
|
Hey @7Pawns, apologies for leaving you in the dark. I made an issue talking about temporary development suspension for the holidays. At the time of my previous comment, I was in the middle of moving flats. I hope to return gradually over January next month. I won't be hitting the ground running, but the first priority will be to test PRs and I hope to get to yours as one of the first. I appreciate your patience and contribution to the project, and I wish you a Merry Christmas (or Happy Holidays if you don't observe Christmas) and a very, very Happy New Year. I will see you up ahead! |
|
I will try and get a look at this tonight, sorry for the long wait and thank you for you patience. |
|
Looks good, thank you very much for this and again apologies it took so long to get to you. I hope in future to have a better process for evaluating PRs. Will merge now |
the-wright-jamie
merged commit 7349a50
into
the-wright-jamie:development
Subtitle of PR
Added support for Quotable Random Quotes and handled failed image fetches.
Resolved #135
Developer Testing Evidence
Evidence of the PR is in action in the section below.
Evidence
You can see we aren't getting any image fetched yet no error thrown
Chrome
Firefox
Edge