Update new wasm hash naming to expected new_wasm_hash #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
approved these changes
Sep 24, 2025
Member
chadoh
left a comment
chadoh
left a comment
There was a problem hiding this comment.
Seems like the right thing to do to me! @willemneal any comments here?
Member
|
An the low level contract invoke the name doesn't matter, since the args are just a vec. So we should update Scaffold stellar to just pass a the bytesN<32>. But completely agree we should use the same name in the official trait!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The argument to
upgradeshould be new_wasm_hash, not wasm_hash, as this is what we're standardizing on per https://developers.stellar.org/docs/build/guides/conventions/upgrading-contracts.Why
Scaffold Stellar assumes new_wasm_hash when upgrading contracts, so this function should use that argument.