docs(example): alter refresh_example to use fb prefix in fb_login_protocol_scheme #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in fact 1cfb158 did a good job - it updated the refresh-example script at the same time So I'm running it again now just to update things and verify this change but then it should be good to go |
|
Something appears to be broken in the example when it moves from react-native 0.75.x to 0.76.x and I haven't quite figured out what. Relates to native module auto-loading as a likely root cause, and symptom is that the example app fails on boot with the Settings native module being null / inaccessible. Reproduces on android with true or false newArchEnabled in gradle.properties. |
this fixes auto-linking, which somehow does not like the github style ref in package.json on react-native 0.76+
|
🎉 This PR is included in version 13.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is not complete, there have been some other direct changes to the example that must be incorporated into the refresh_example.sh script so they aren't lost
After altering refresh-example to make that change, then refresh-example should be committed one more time, and then the results of a run should be committed (with all the updated example files...)