Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): adopt facebook-android-sdk v18.0.0 #595

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

hamadmarhoon
Copy link
Contributor

This pull request updates the Android Facebook SDK to version 18.

  • Reason: SDK v18 introduces better support for Google Play Billing Library v5 - v7
  • Tested: Verified on both Android and iOS using the example app.
  • No breaking changes observed.

@mikehardy
Copy link
Collaborator

Hey there! Awesome, this looks right on for facebook-android-sdk
I see ios had a v18 release as well - https://github.com/facebook/facebook-ios-sdk/releases
You mention you checked that iOS works but I don't see the podspec dep for the facebook-ios-sdk in this PR, did you test it but not commit it?

@mikehardy mikehardy added the needs more info waiting on original poster to provide details label Jan 16, 2025
@hamadmarhoon
Copy link
Contributor Author

Hello @mikehardy! I wasn’t aware that the iOS SDK had an update as well and initially intended this PR to update only the Android SDK. However, I’ve now gone ahead and updated the iOS SDK version as well. Please let me know if there’s anything else I should adjust. Thanks again for reviewing this!

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like what I'd expect, thank you!

@mikehardy mikehardy added pending-merge Just waiting on clean CI test run. Any maintainer should feel free to merge if CI is passing. and removed needs more info waiting on original poster to provide details labels Jan 16, 2025
@mikehardy mikehardy merged commit c325978 into thebergamo:master Jan 16, 2025
4 checks passed
@mikehardy mikehardy removed the pending-merge Just waiting on clean CI test run. Any maintainer should feel free to merge if CI is passing. label Jan 16, 2025
github-actions bot pushed a commit that referenced this pull request Jan 16, 2025
## [13.4.0](v13.3.0...v13.4.0) (2025-01-16)

### Features

* adopt v18.0.0 of facebook-ios-sdk and facebook-android-sdk ([#595](#595)) ([c325978](c325978))
Copy link

🎉 This PR is included in version 13.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants