GHA: release management for the firebase C++ SDK #1
Conversation
Add some rules to release the content from the build to preserve the content. Furthermore, begin packaging and deploying a nuget package enabling the future consumption within the Arc build.
| @@ -52,3 +52,37 @@ jobs: | |||
| with: | |||
| name: firebase-windows-amd64 | |||
| path: ${{ github.workspace }}/BuildRoot/Library/firebase | |||
|
|
|||
| - run: | | |||
| echo build_tag=$(date +%Y%m%d.$(date +%-H/6 | bc)) >> ${GITHUB_ENV} | |||
There was a problem hiding this comment.
lol what's up w/ the inner $()?
(why is quarter-day a meaningful unit here?)
There was a problem hiding this comment.
Quarter day is a meaningful unit only in that it is copy-pasta. We really just need a counter. The toolchain builds build occur every 6 hours, so we get quarter days.
There was a problem hiding this comment.
lol IMO just use full hours.minutes.seconds and avoid potential future confusion. But that's just me.
| - name: publish nuget | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.NUGET_TOKEN }} | ||
| GITHUB_USERNAME: thebrowsercompany-bot2 |
There was a problem hiding this comment.
I guess this isn't something we're hoping to upstream?
There was a problem hiding this comment.
Nope, I see no reason we would ever upstream the nuget package. If anything, we might consider switching to the upstream package if we could.
| run: | | ||
| nuget sources list | findstr "%NUGET_SOURCE_NAME%" | ||
| if errorlevel 0 ( nuget sources remove -name %NUGET_SOURCE_NAME% ) | ||
| nuget sources Add -Name %NUGET_SOURCE_NAME% -Source %NUGET_PUBLISH_URL% -username %GITHUB_USERNAME% -password %GITHUB_TOKEN% -StorePasswordInClearText |
There was a problem hiding this comment.
IDK what "StorePasswordInClearText" means but it sounds...exciting?
There was a problem hiding this comment.
Exciting is one word for it. This is copy-pasta from thebrowsercompany/swiftwinrt's rules.
| @@ -0,0 +1,41 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
I know absolutely nothing about nuget/nuspec so might be nice to get a review from someone who does.
Add some rules to release the content from the build to preserve the content. Furthermore, begin packaging and deploying a nuget package enabling the future consumption within the Arc build.