workaround widevine issue by reducing mach exception mask

thebrowsercompany · Jun 28, 2023 · 19ba3d1 · 19ba3d1
1 parent d277532
commit 19ba3d1
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_MachException.c b/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_MachException.c
@@ -457,8 +457,12 @@ installExceptionHandler(void)
     int error;
 
     const task_t thisTask = mach_task_self();
-    exception_mask_t mask = EXC_MASK_BAD_ACCESS | EXC_MASK_BAD_INSTRUCTION | EXC_MASK_ARITHMETIC
-        | EXC_MASK_SOFTWARE | EXC_MASK_BREAKPOINT;
+    // This is the default, which breaks widevine:
+    // `exception_mask_t mask = EXC_MASK_BAD_ACCESS | EXC_MASK_BAD_INSTRUCTION | EXC_MASK_ARITHMETIC | EXC_MASK_SOFTWARE | EXC_MASK_BREAKPOINT;`
+    // Following is used by chromium's crashpad, which works with widevine
+    // We're not seeing some crashed being picked up by the mach exception handler with this
+    // but they still end up in Sentry via the signal handler.
+    exception_mask_t mask = EXC_MASK_CRASH | EXC_MASK_BAD_ACCESS;
 
     SentryCrashLOG_DEBUG("Backing up original exception ports.");
     kr = task_get_exception_ports(thisTask, mask, g_previousExceptionPorts.masks,