Skip to content

Commit

Permalink
Revert "firebase: use bridging header and remove unnecessary header"
Browse files Browse the repository at this point in the history
This reverts commit bb7ec5c.
  • Loading branch information
darinf committed Feb 16, 2024
1 parent 7dce8b6 commit e769cc4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
include:
- branch: development
tag: DEVELOPMENT-SNAPSHOT-2024-02-08-a
options: -Xswiftc "-I${env:SDKROOT}\usr\lib\swift_static\windows" -Xswiftc "-I${env:SDKROOT}\..\..\..\..\..\..\Toolchains\0.0.0+Asserts\usr\include"
options: -Xswiftc "-I${env:SDKROOT}\usr\lib\swift_static\windows"

name: Swift ${{ matrix.tag }}

Expand Down
4 changes: 2 additions & 2 deletions Sources/firebase/include/FirebaseCore.hh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#include <firebase/util.h>

#include <swift/bridging>
#include <stdio.h>

namespace swift_firebase::swift_cxx_shims::firebase {

Expand All @@ -14,7 +14,7 @@ typedef void (*FutureCompletionType)(void*);
// Swift. We can ignore the `FutureBase` param as the Swift caller can just
// retain the Future as part of its closure.
template <class R>
class SWIFT_CONFORMS_TO_PROTOCOL(FirebaseCore.FutureProtocol)
class __attribute__((swift_attr("conforms_to:FirebaseCore.FutureProtocol")))
Future : public ::firebase::Future<R> {
public:
typedef R ResultType;
Expand Down

0 comments on commit e769cc4

Please sign in to comment.