Implement runTransaction and batch support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darinf
changed the title
brianmichel
reviewed
Feb 16, 2024
| @@ -34,6 +34,63 @@ extension Firestore { | |||
| public func collection(_ collectionPath: String) -> CollectionReference { | |||
| swift_firebase.swift_cxx_shims.firebase.firestore.firestore_collection(self, std.string(collectionPath)) | |||
| } | |||
|
|
|||
| public func runTransaction(_ updateBlock: @escaping (Transaction, UnsafePointer<NSError?>?) -> Any?, completion: @escaping (Any?, Error?) -> Void) { | |||
There was a problem hiding this comment.
Will this need changes from https://github.com/thebrowsercompany/swift-firebase/pull/30/files for the error pointer?
There was a problem hiding this comment.
Yes, that PR builds on top of this one. I wrote that one once I was able to try building against Arc. Rather than complicate things by folding it into this PR, I just left them as separate. Hope that works!
brianmichel
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
Transaction,TransactionOptionsandWriteBatchtypesVoidFutureas workaround forFuture<void>TransactionWeakReferenceas a wrapper forTransactionsinceTransactioncannot be exposed directly to Swift given that it is a non-copyable type.