Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise the way FirestoreErrorCode can be initialized #40

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Revise the way FirestoreErrorCode can be initialized #40

merged 4 commits into from
Mar 6, 2024

Commits on Mar 5, 2024

  1. Revise the way FirestoreErrorCode can be initialized 

    Hide the initializers that take the C++ type. Allow consumers to write
code like `FirestoreErrorCode(.permissionDenied)`.
    @darinf
    darinf committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b4dda16 View commit details
    Browse the repository at this point in the history

  2. fix

    @darinf
    darinf committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f128f47 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. simplify

    @darinf
    darinf committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    f2629eb View commit details
    Browse the repository at this point in the history

  2. back to a separate initializer

    @darinf
    darinf committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e1e45f5 View commit details
    Browse the repository at this point in the history